Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[major] Move Extmodule Params to Instantiation #46

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Commits on Sep 19, 2022

  1. [major] Move Extmodule Params to Instantiation

    This changes the format for FIRRTL external modules to move parameter
    values to the site of instantiation as opposed to being declared along
    with the extmodule definition.  This has the added benefit of removing
    the "defname" as this is now unified with the name of the external
    module.
    
    Signed-off-by: Schuyler Eldridge <[email protected]>
    seldridge committed Sep 19, 2022
    Configuration menu
    Copy the full SHA
    8f79a2b View commit details
    Browse the repository at this point in the history

Commits on Sep 20, 2022

  1. squash! [major] Move Extmodule Params to Instantiation

    Also allow for SInt parameters.
    seldridge committed Sep 20, 2022
    Configuration menu
    Copy the full SHA
    442b8b2 View commit details
    Browse the repository at this point in the history
  2. squash! [major] Move Extmodule Params to Instantiation

    Update EBNF grammar for external module parameters.
    seldridge committed Sep 20, 2022
    Configuration menu
    Copy the full SHA
    75126fc View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    48093c7 View commit details
    Browse the repository at this point in the history
  4. squash! squash! [major] Move Extmodule Params to Instantiation

    Make parameter types explicitly boxed.  Restrict the locations where
    parameter types can show up to nodes and external module parameters.
    Allow aggregate, passive parameter types.
    
    Add a new parameter primitive operation section.  This is presently
    incomplete, but includes a single `primAdd` operation to show how this
    would work.
    
    Update the EBNF grammar and the FIRRTL syntax highlighting XML file.
    seldridge committed Sep 20, 2022
    Configuration menu
    Copy the full SHA
    dbb406b View commit details
    Browse the repository at this point in the history