Revert PR 438 with shortened SHA test vector #463
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fix is unnecessary because the failure scenario is already accounted for by a previous fix that uses a C macro/preprocessor conditional to select an appropriate test vector for the sha accel smoke test based on the Caliptra configuration (Core vs Seed). Leaving a large vector in place is advantageous for testing the Core mode to ensure large messages work as expected, though the short vector is required for the Seed smoke test in order to compile the code.
Nitsirks
approved these changes
Mar 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The fix from PR #438 is unnecessary because the failure scenario is already accounted for by a previous fix (38053da) that uses a C macro/preprocessor conditional to select an appropriate test vector for the sha accel smoke test based on the Caliptra configuration (Core vs Seed). Leaving a large vector in place is advantageous for testing the Core mode to ensure large messages work as expected, though the short vector is required for the Seed smoke test in order to compile the code.