Add hitTolerance option to all annotations #902
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hello! Can I somehow help with moving this to production? 🙂 |
|
ping :) |
|
I'm interested in this as well |
LeeLenaleee
reviewed
Aug 22, 2024
Co-authored-by: Jacco van den Berg <[email protected]>
|
@LeeLenaleee ready for your review. I have also changed the tolerance for fixture/label/border.js test from 55 to 57. The test is correct but the small difference should be caused by new browser version. |
LeeLenaleee
approved these changes
Sep 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #900
This PR is add new options,
hitTolerance, which is a number and represents the amount of pixels to add for interacting on annotation elements.TODO