Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add annotations option to the plugin configuration documentation #891

Merged
merged 2 commits into from
Sep 19, 2024

Conversation

stockiNail
Copy link
Collaborator

This PR is adding the annotations option to the plugin configuration documentation.

Even if it sounds obvious, it was missing and it's also scriptable.

This will inform the user that the annotations can be created dynamically by a callback, where the amount of annotations could change depending on the use case.

@stockiNail stockiNail added this to the 3.1.0 milestone May 22, 2023
@stockiNail
Copy link
Collaborator Author

@LeeLenaleee I cannot merge because the checks are not available anymore and therefore the button is disable. I can switch to draft and again to ready for review in order to execute again the GHAs.

@LeeLenaleee
Copy link
Collaborator

Yeah, or you can change something push it and revert it and push that again

@stockiNail
Copy link
Collaborator Author

@LeeLenaleee merging #902 I just need to rebase ;)

@stockiNail stockiNail merged commit ca13aaf into chartjs:master Sep 19, 2024
10 checks passed
@stockiNail stockiNail deleted the addAnnotationsDoc branch September 19, 2024 06:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants