Chunked DA txs #925
Merged
Chunked DA txs #925
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Add vout index for prev tx * replace prev_tx logic with prev_utxo logic * remove RawUTXO --------- Co-authored-by: eyusufatik <[email protected]>
* depend only on wtxid * verify merkle root of coinbase tx, use zkvm efficient sh256 and bitcoin merkle tree * remove unused asserts * pr fixes * pr fixes
This was
linked to
issues
Aug 15, 2024
kpp
commented
Aug 16, 2024
* get ready for test fixes * fix tests * reactivate some of the verifier tests * fix remaning bitcoin-da tests * cleanup
* Add merkle tree tests (#995) * Add merkle tree tests * Add 1 tx test to bitcoin compare --------- Co-authored-by: yaziciahmet <yaziciahmetcleargmail.com> * Fix errors/lints --------- Co-authored-by: Ahmet Yazıcı <[email protected]>
rakanalh
reviewed
Aug 19, 2024
Not really. Esad dumped a bitcoin block with txs (see mock_txs.txt) and all tests passed (except for CI but I will fix it). Tests are: parse seq commitment, verify inclusion etc. |
waiting on @jfldde for e2e bitcoin framework 🙄 |
kpp
commented
Aug 20, 2024
kpp
commented
Aug 20, 2024
kpp
commented
Aug 20, 2024
kpp
commented
Aug 20, 2024
kpp
commented
Aug 20, 2024
kpp
commented
Aug 20, 2024
kpp
commented
Aug 20, 2024
kpp
commented
Aug 20, 2024
eyusufatik
requested changes
Aug 20, 2024
kpp
commented
Aug 20, 2024
kpp
commented
Aug 20, 2024
This was referenced Aug 20, 2024
eyusufatik
approved these changes
Aug 20, 2024
This was referenced Aug 20, 2024
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR implements a new DA tx format. Here is the format: #871 (comment)
Also instead of txids we use wtxids for prefixes. So we don't try to find nonces for txid, we find nonces so that wtxid matches a specific prefix. It was done for #991 better inclusion proof (O(log N) instead of O(N)).
In order to speed up proofs when a DA block has both zkproof and seq commitment I implemented a trick to parse only DA tx that are related to our proofs. Before we had 1 prefix, but now there are two of them (#972). Before the prefix was 00, now they are:
Where light_client - zkproofs (diffs), batch_proof - currently only a tx with sequencer commitment, but will be extended with forced transactions sometime in the future.