Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DA: Don't choose utxos on every nonce probe #1023

Open
kpp opened this issue Aug 20, 2024 · 3 comments
Open

DA: Don't choose utxos on every nonce probe #1023

kpp opened this issue Aug 20, 2024 · 3 comments
Labels
M - good first issue Good for newcomers P-low Low priority T - enhancement New feature or request

Comments

@kpp
Copy link
Contributor

kpp commented Aug 20, 2024

Followup of #925:

#925 (comment):

since we decided to go with wtxid for prefixes, now we have to choose utxos every time we try a nonce.
this can be improved actually.

How?

We loop over nonceCalculate reveal addr Then build commit tx — which selects utxos

@kpp kpp added the T - enhancement New feature or request label Aug 20, 2024
@kpp kpp mentioned this issue Aug 20, 2024
7 tasks
@kpp kpp added the P-low Low priority label Aug 20, 2024
@eyusufatik
Copy link
Member

the utxos chosen in the commit tx affect the commit txid

which affects reveal tx's txid and wtxid

but once a set of utxos are chosen, we don't need to re-select them.

one problem that may rise is taproot addresses don't have a fixed length and that might change the tx sizes? (I'm not completely sure about this)

@kpp
Copy link
Contributor Author

kpp commented Oct 1, 2024

I am not quite sure if it's a correct strategy. If fee increases while we are mining wtxid, we need to re-select utxos if their sum < fee.

@kpp kpp added the M - good first issue Good for newcomers label Oct 1, 2024
@eyusufatik
Copy link
Member

I am not quite sure if it's a correct strategy. If fee increases while we are mining wtxid, we need to re-select utxos if their sum < fee.

we don't requery fees while mining, but yes. we should actually at some intervals

@eyusufatik eyusufatik added this to the Mainnet Should milestone Nov 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
M - good first issue Good for newcomers P-low Low priority T - enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants