Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: testing timeout usage #401

Merged
merged 5 commits into from
May 31, 2024
Merged

fix: testing timeout usage #401

merged 5 commits into from
May 31, 2024

Commits on May 29, 2024

  1. chore: remove duplicate timeout definitions

    The make test command was using the KNUU_TIMEOUT and -timeout variables.
    I removed the -timeout flags as a default of 10m is sufficient.
    We have a .env file that we can use for the KNUU_TIMEOUT so I removed it
    from the command itself.
    MSevey committed May 29, 2024
    Configuration menu
    Copy the full SHA
    2591c1e View commit details
    Browse the repository at this point in the history
  2. fix: clean up ci test file

    The merge_group trigger wasn't set so test won't be run on the merge
    queue.
    We were setting the KNUU_TIMEOUT specifically in the test, but this
    wasn't being honored due to the reasons in the previous commit.
    MSevey committed May 29, 2024
    Configuration menu
    Copy the full SHA
    74c67eb View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    5236cc6 View commit details
    Browse the repository at this point in the history

Commits on May 30, 2024

  1. Configuration menu
    Copy the full SHA
    4fb750f View commit details
    Browse the repository at this point in the history

Commits on May 31, 2024

  1. Configuration menu
    Copy the full SHA
    436ed90 View commit details
    Browse the repository at this point in the history