fix: testing timeout usage

[MSevey]

Overview

This PR:

• The merge_group trigger wasn't set so test won't be run on the merge queue.
• We were setting the KNUU_TIMEOUT specifically in the test, but this wasn't being honored due to the make test command was using the KNUU_TIMEOUT and -timeout variables.
• I removed the -timeout flags as a default of 10m is sufficient. We have a .env file that we can use locally for the KNUU_TIMEOUT so I removed it from the command itself.
• Deleted the .env file
• I also removed the branch restriction on the PR trigger.

Summary by CodeRabbit

• Chores
  • Increased session timeout from 60 minutes to 120 minutes for improved user experience.
  • Adjusted workflow triggers to enhance CI/CD pipeline efficiency.

[coderabbitai]

Warning

Review failed

The pull request is closed.

Walkthrough

The recent changes involve modifications to the .env file, .github/workflows/knuu_testing.yml, and the Makefile. The .env file's KNUU_TIMEOUT setting was increased to 120 minutes, and the LOG_LEVEL comment was clarified. The GitHub workflow was updated to trigger on specific branch pushes and support the merge_group event. The Makefile was simplified by removing the KNUU_TIMEOUT environment variable setting for tests.

Changes

Files/Paths	Change Summaries
.env	Increased KNUU_TIMEOUT from 60 to 120 minutes and clarified LOG_LEVEL comment.
.github/workflows/knuu_testing.yml	Adjusted branch specification for push events and added support for the merge_group event.
Makefile	Removed KNUU_TIMEOUT environment variable setting and associated timeout value from the test target.

Poem

In the land of code, a rabbit hops,
Tweaking timeouts, making stops.
Workflows now so smart and keen,
Testing flows like a dream.
Makefile simpler, clean and bright,
CodeRabbit's touch, pure delight. 🐇✨

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

• X
• Mastodon
• Reddit
• LinkedIn

Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai generate interesting stats about this repository and render them as a table.
  • @coderabbitai show all the console.log statements in this repository.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[coderabbitai]

Actionable comments posted: 0

Review Details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between 74e6413 and 74c67eb.

Files selected for processing (3)

• .env (1 hunks)
• .github/workflows/knuu_testing.yml (1 hunks)
• Makefile (1 hunks)

Files skipped from review due to trivial changes (3)

• .env
• .github/workflows/knuu_testing.yml
• Makefile

[mojtaba-esk]

It is better to start practice the new knuu version