feat: Increase namespace size #171
Conversation
| /// @dev Parity share namespace ID | ||
| NamespaceID internal constant PARITY_SHARE_NAMESPACE_ID = NamespaceID.wrap(0xFFFFFFFFFFFFFFFF); | ||
| NamespaceID internal constant PARITY_SHARE_NAMESPACE_ID = | ||
| NamespaceID.wrap(0xFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFFF); |
There was a problem hiding this comment.
[optional] in a separate PR it may make sense to rename namespace ID to namespace for similar reasons to celestiaorg/nmt#206
| @@ -1,7 +1,7 @@ | |||
| // SPDX-License-Identifier: Apache-2.0 | |||
| pragma solidity ^0.8.19; | |||
|
|
|||
| type NamespaceID is bytes8; | |||
| type NamespaceID is bytes29; | |||
There was a problem hiding this comment.
Hmmm. Should this instead be a struct of a bytes1 and bytes28 https://github.com/celestiaorg/celestia-app/blob/3e6d22cfde678efac4f7c078228e9f294a7a9b8d/specs/src/specs/namespace.md#overview? The actual namespace ID isn't just one field. There isn't any code in the QGB proper that cares, but perhaps downstream contracts might care (e.g. to ensure their data was posted to the correct namespace).
Doing that would increase costs though.
There was a problem hiding this comment.
Does it make sense to handle this in a separate PR? I can create an issue for it and then make the change along with this one #172
Overview
Closes #148
Checklist