Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use a struct for namespace #174

Closed
rach-id opened this issue Aug 11, 2023 · 0 comments · Fixed by #175
Closed

Use a struct for namespace #174

rach-id opened this issue Aug 11, 2023 · 0 comments · Fixed by #175
Assignees
@rach-id
Labels
contracts

Comments

@rach-id
Copy link
Member

rach-id commented Aug 11, 2023 

          Hmmm. Should this instead be a struct of a `bytes1` and `bytes28` https://github.com/celestiaorg/celestia-app/blob/3e6d22cfde678efac4f7c078228e9f294a7a9b8d/specs/src/specs/namespace.md#overview? The actual namespace ID isn't just one field. There isn't any code in the QGB proper that cares, but perhaps downstream contracts might care (e.g. to ensure their data was posted to the correct namespace).

Doing that would increase costs though.

Originally posted by @adlerjohn in #171 (comment)
@rach-id rach-id self-assigned this Aug 11, 2023
@rach-id rach-id mentioned this issue Aug 12, 2023
Merged
5 tasks
@adlerjohn adlerjohn linked a pull request Aug 22, 2023 that will close this issue
feat!: use a struct for namespace and rename namespaceID #175
Merged
5 tasks
rach-id added a commit that referenced this issue Sep 8, 2023
@rach-id @rootulp
feat!: use a struct for namespace and rename namespaceID (#175)
eb7a4e7 
<!--
Please read and fill out this form before submitting your PR.

Please make sure you have reviewed our contributors guide before
submitting your
first PR.
-->

## Overview

<!-- 
Please provide an explanation of the PR, including the appropriate
context,
background, goal, and rationale. If there is an issue with this
information,
please provide a tl;dr and link the issue. 
-->

Closes #172
and #174


## Checklist

<!-- 
Please complete the checklist to ensure that the PR is ready to be
reviewed.

IMPORTANT:
PRs should be left in Draft until the below checklist is completed.
-->

- [ ] New and updated code has appropriate documentation
- [ ] New and updated code has new and/or updated testing
- [ ] Required CI checks are passing
- [ ] Visual proof for any user facing features like CLI or
documentation updates
- [ ] Linked issues closed with keywords

---------

Co-authored-by: Rootul P <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rach-id rach-id

Labels
contracts
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat!: use a struct for namespace and rename namespaceID rach-id/quantum-gravity-bridge
1 participant
@rach-id