Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: try adding double braces to the variable reference #2041

Merged
merged 6 commits into from
Jan 9, 2025
+2 −2
Merged

fix: try adding double braces to the variable reference #2041

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
a5cbba0
fix: try adding double braces to the variable reference
andrewleith Jan 9, 2025
475f2ae
chore: add debug workflow to figure this out
andrewleith Jan 9, 2025
07b27f7
chore: try again
andrewleith Jan 9, 2025
0846120
chore: try again again
andrewleith Jan 9, 2025
289ab2d
remove debug workflow
andrewleith Jan 9, 2025
4c81e63
update workflows FOR THE LAST TIME
andrewleith Jan 9, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/cypress-staging.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,5 +38,5 @@ jobs:
- name: Notify Slack channel if this job failed
if: ${{ failure() }}
run: |
json='{"text": "<!here> Staging a11y tests failed: <https://github.com/cds-snc/notification-admin/actions/runs/'${GITHUB_RUN_ID}'|see failure details> !"}'
json='{"text": "<!here> Staging a11y tests failed: <https://github.com/cds-snc/notification-admin/actions/runs/'${{GITHUB_RUN_ID}}'|see failure details> !"}'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
json='{"text": "<!here> Staging a11y tests failed: <https://github.com/cds-snc/notification-admin/actions/runs/'${{GITHUB_RUN_ID}}'|see failure details> !"}'
json='{"text": "<!here> Staging a11y tests failed: <https://github.com/cds-snc/notification-admin/actions/runs/'$GITHUB_RUN_ID'|see failure details> !"}'

curl -X POST -H 'Content-type: application/json' --data "$json" ${{ secrets.SLACK_WEBHOOK }}
2 changes: 1 addition & 1 deletion .github/workflows/docker.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -121,5 +121,5 @@ jobs:
- name: Notify Slack channel if this job failed
if: ${{ failure() }}
run: |
json='{"text":"<!here> CI is failing in <https://github.com/cds-snc/notification-admin/actions/runs/'${GITHUB_RUN_ID}'|see failure details> !"}'
json='{"text":"<!here> CI is failing in <https://github.com/cds-snc/notification-admin/actions/runs/'${{GITHUB_RUN_ID}}'|see failure details> !"}'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
json='{"text":"<!here> CI is failing in <https://github.com/cds-snc/notification-admin/actions/runs/'${{GITHUB_RUN_ID}}'|see failure details> !"}'
json='{"text":"<!here> CI is failing in <https://github.com/cds-snc/notification-admin/actions/runs/'$GITHUB_RUN_ID'|see failure details> !"}'

curl -X POST -H 'Content-type: application/json' --data "$json" ${{ secrets.SLACK_WEBHOOK }}
Loading