fix: try adding double braces to the variable reference #2041
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🧪 Review environmenthttps://bvrystmflc7sp6rfiqqwmf4ck40crfun.lambda-url.ca-central-1.on.aws/ |
ben851
reviewed
Jan 9, 2025
| @@ -38,5 +38,5 @@ jobs: | |||
| - name: Notify Slack channel if this job failed | |||
| if: ${{ failure() }} | |||
| run: | | |||
| json='{"text": "<!here> Staging a11y tests failed: <https://github.com/cds-snc/notification-admin/actions/runs/'${GITHUB_RUN_ID}'|see failure details> !"}' | |||
| json='{"text": "<!here> Staging a11y tests failed: <https://github.com/cds-snc/notification-admin/actions/runs/'${{GITHUB_RUN_ID}}'|see failure details> !"}' | |||
There was a problem hiding this comment.
Suggested change
| json='{"text": "<!here> Staging a11y tests failed: <https://github.com/cds-snc/notification-admin/actions/runs/'${{GITHUB_RUN_ID}}'|see failure details> !"}' | |
| json='{"text": "<!here> Staging a11y tests failed: <https://github.com/cds-snc/notification-admin/actions/runs/'$GITHUB_RUN_ID'|see failure details> !"}' |
ben851
reviewed
Jan 9, 2025
.github/workflows/docker.yaml
Outdated
| @@ -121,5 +121,5 @@ jobs: | |||
| - name: Notify Slack channel if this job failed | |||
| if: ${{ failure() }} | |||
| run: | | |||
| json='{"text":"<!here> CI is failing in <https://github.com/cds-snc/notification-admin/actions/runs/'${GITHUB_RUN_ID}'|see failure details> !"}' | |||
| json='{"text":"<!here> CI is failing in <https://github.com/cds-snc/notification-admin/actions/runs/'${{GITHUB_RUN_ID}}'|see failure details> !"}' | |||
There was a problem hiding this comment.
Suggested change
| json='{"text":"<!here> CI is failing in <https://github.com/cds-snc/notification-admin/actions/runs/'${{GITHUB_RUN_ID}}'|see failure details> !"}' | |
| json='{"text":"<!here> CI is failing in <https://github.com/cds-snc/notification-admin/actions/runs/'$GITHUB_RUN_ID'|see failure details> !"}' |
ben851
approved these changes
Jan 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary | Résumé
3rd attempt at having this workflow pass the github_run_id properly to slack.