fix various translations #1997

amazingphilippe · 2024-11-15T21:26:33Z

Summary | Résumé

This fixes missing translatiosn identified here

A few techniques used based on context:

remove translation when not needed. Ex we dont need to translate a "value" attribute, or html strings
add translation
edit the translation reference in the code.

Test instructions | Instructions pour tester la modification

I need to provide a list of pages to look at. Most is visible text, some are hidden aria attributes.

github-actions · 2024-11-15T21:33:21Z

🧪 Review environment

https://yjmm6n5umedv5bqrj6fgyzlxpq0hwcjw.lambda-url.ca-central-1.on.aws/

andrewleith

Amazing work, thank you for this!

There are still 4 missing, I'll see if I can fix them up:

missing from fr.csv : app/templates/components/remaining-messages-summary.html:87 : "Below limit: "
missing from fr.csv : app/templates/components/remaining-messages-summary.html:85 : "Near limit: "
missing from fr.csv : app/templates/components/remaining-messages-summary.html:83 : "At limit: "
missing from fr.csv : app/templates/views/service-settings/email_from.html:26 : "Maximum 64 characters with no spaces. Characters can include letters, numbers, dots, dashes, and

…of `.html` files and not just `.py` files

andrewleith · 2024-11-18T16:25:38Z

Updating the branch should fix that test failure, trying now...

andrewleith

Think we are all set now!

amazingphilippe · 2024-11-18T18:13:25Z

app/templates/components/message-count-label.html

@@ -104,9 +104,9 @@

  {%- if session["userlang"] == "fr" -%}
    {%- if count <= 1 -%}
-      {{ _('addresse courriel problématique') }}
+      addresse courriel problématique


tested, works as expected

amazingphilippe · 2024-11-18T18:20:21Z

app/templates/views/api/callbacks/delivery-status-callback.html

@@ -41,13 +41,13 @@ <h2 class="heading-small">
          autocomplete='new-password'
        ) }}
        {% set test_response_txt = _('Test response time')  if has_callback_config else None %}
-        {% set test_response_value = _('test_response_time') if has_callback_config else None %}
+        {% set test_response_value = 'test_response_time' if has_callback_config else None %}


works as expected

amazingphilippe · 2024-11-18T18:23:36Z

app/templates/views/email-branding/branding-goc.html

@@ -24,7 +24,8 @@ <h2 class="heading-small" id="goc_branding-label">{{ _('Change the default langu
        {% call form_wrapper() %}
          {{ radios(form.goc_branding, hide_legend=True, testid="goc_branding") }}

-          {{ _('<a class="-mt-12 block" data-testid="goto-pool" href="{}">{}</a>').format(url_for('main.review_branding_pool', service_id=current_service.id), _('Select alternate logo')) }}
+          <a class="-mt-12 block" data-testid="goto-pool"
+            href="{{ url_for('main.review_branding_pool', service_id=current_service.id) }}">{{ _('Select alternate logo') }}</a>


tested, link still works

amazingphilippe · 2024-11-18T18:23:59Z

app/templates/views/email-branding/branding-pool.html

@@ -29,7 +29,8 @@
              <div class="js-stick-at-bottom-when-scrolling">
                <div class="flex flex-row-reverse justify-end items-center">
                  <div class="ml-10">
-                    {{ _('<a href="{}" data-testid="goto-request">{}</a>').format(url_for('main.create_branding_request', service_id=current_service.id), _('Request a new logo')) }}
+                    <a href="{{ url_for('main.create_branding_request', service_id=current_service.id) }}" data-testid="goto-request">{{


tested, link still works

amazingphilippe · 2024-11-18T18:25:34Z

app/templates/views/service-settings/email_from.html

@@ -23,8 +23,7 @@

  {% call form_wrapper() %}
    {% set save_txt = _('Save') %}
-    {% set hint_txt = _('Maximum 64 characters with no spaces. Characters can include letters, numbers, dots, dashes, and
-    underscores.') %}
+    {% set hint_txt = _('Maximum 64 characters with no spaces. Characters can include letters, numbers, dots, dashes, and underscores.') %}


amazingphilippe · 2024-11-18T18:26:34Z

app/translations/csv/fr.csv

@@ -56,6 +56,7 @@
 "Who runs this service?","Qui assure la gestion du service?"
 "What’s your key called?","Quel est le nom de votre clé?"
 "Numbers of text messages per fiscal year","Nombre de messages texte par exercice financier"
+"Free text messages per fiscal year","Messages texte gratuits par exercice financier"


amazingphilippe · 2024-11-18T18:27:23Z

app/translations/csv/fr.csv

@@ -127,6 +128,7 @@
 "Text message","Message texte"
 "Choose a folder","Choisissez un dossier"
 "Create template","Créer un gabarit"
+"Create category","Créer une catégorie"


amazingphilippe · 2024-11-18T18:28:59Z

app/translations/csv/fr.csv

@@ -653,6 +655,7 @@
 "Count in list of live services","Compte dans la liste de services activés"
 "Organisation","Organisation"
 "Free text message allowance","Nombre de messages texte gratuits"
+"Free text messages per year","Nombre de messages texte gratuits par année"


I'll remove this one and replace it with the "fiscal year" equivalent above

amazingphilippe · 2024-11-18T18:29:24Z

app/translations/csv/fr.csv

@@ -1080,6 +1083,7 @@
 "Daily text message limit","Limite quotidienne de message texte"
 "Last edited","Dernière modification&nbsp;: "
 "See previous versions","Voir les versions précédentes"
+"Version {}","Version {}"


amazingphilippe · 2024-11-18T18:30:17Z

app/translations/csv/fr.csv

@@ -1426,6 +1430,7 @@
 "Filter by year","Filtrer par année"
 "Filter by status","Filtrer par état de livraison"
 "Filter by template type","Filtrer par type de gabarit"
+"Filter by template type and category","Filtrer par type et catégorie de gabarit"


amazingphilippe · 2024-11-18T18:37:00Z

app/translations/csv/fr.csv

@@ -1716,6 +1724,7 @@
 "For example: Treasury Board of Canada Secretariat","Par exemple&nbsp;: Secrétariat du Conseil du Trésor du Canada"
 "For example: Canadian Digital Service","Par exemple&nbsp;: Service numérique canadien"
 "Not on list?","Vous ne trouvez pas?"
+"Not on the list? Add your organization","Vous ne trouvez pas? Ajoutez votre organisation"


amazingphilippe · 2024-11-18T18:38:07Z

app/translations/csv/fr.csv

 "Daily usage","Utilisation quotidienne"
 "Message limits reset each night at 7pm Eastern Time","Les limites d’envoi sont réinitialisées chaque soir à 19 h, heure de l’Est"
 "Maximum 612 characters. Some messages may be too long due to custom content.","612 caractères au maximum. Certains messages peuvent être trop longs en raison de leur contenu personnalisé."
 "Too many characters","Limite de caractère atteinte"
 "New features","Nouvelles fonctionnalités"
 "Your","Votre"
+"your","votre"


…tions' into fix/missing-translations

amazingphilippe · 2024-11-20T19:15:40Z

app/translations/csv/fr.csv

@@ -1766,8 +1775,9 @@
 "Annual maximum</br>(April 1 to March 31)","Maximum par exercice financier"
 "To request a daily limit above {} emails, {}","Si vous désirez obtenir une limite quotidienne supérieure à {} courriels, veuillez {}"
 "To request a daily limit above {} text messages, {}","Si vous désirez obtenir une limite quotidienne supérieure à {} messages texte, veuillez {}"
-"You can try sending these messages after {} Eastern Time. Check your {}.","Vous pourrez envoyer ces messages après {} heures, heure de l’Est. Comparez {}"
-"You can try sending this message after {} Eastern Time. Check your {}.","Vous pourrez envoyer ce message après {} heures, heure de l’Est. Comparez {}"
+"You can try sending these messages after {} Eastern Time. Check your {}.","Vous pourrez envoyer ces messages après {} heures, heure de l’Est. Comparez {}."


We can remove the ones with "Check your {}". We use the one with just "Check {}"
Otherwise these work

amazingphilippe · 2024-11-20T20:52:57Z

app/translations/csv/fr.csv

+"Below limit: ","En dessous de la limite : "
+"Near limit: ","Limite presqu’atteinte : "
+"At limit: ","Limite atteinte : "


amazingphilippe · 2024-11-20T20:54:23Z

app/translations/csv/fr.csv

@@ -2004,3 +2018,5 @@
 "Annual text message limit","(FR) Limite maximale de messages texte par exercice financier"
 "Annual email message limit","(FR) Limite maximale de messages électroniques par exercice financier"
 "Annual email limit","(FR) Limite maximale de courriels par exercice financier"
+"Test response time","Tester le temps de réponse"


amazingphilippe

Went through all instances of missing strings. Looks good to me.

fix various translations

4f85b07

amazingphilippe requested a review from andrewleith November 15, 2024 21:26

andrewleith requested changes Nov 18, 2024

View reviewed changes

andrewleith added 4 commits November 18, 2024 13:26

fix: update translation strings to include space

9a833cc

fix: remove line break from text

42bf753

fix: update make test-translations to look for translations inside …

3ebe8bc

…of `.html` files and not just `.py` files

Merge branch 'main' into fix/missing-translations

2d14dc4

chore: add missing translation

e3e0d6e

andrewleith approved these changes Nov 18, 2024

View reviewed changes

amazingphilippe commented Nov 18, 2024

View reviewed changes

amazingphilippe added 2 commits November 18, 2024 18:46

update settings page title

22cb080

Merge remote-tracking branch 'refs/remotes/origin/fix/missing-transla…

2279fd5

…tions' into fix/missing-translations

amazingphilippe commented Nov 20, 2024

View reviewed changes

remove redundant translations

c00b4b6

amazingphilippe commented Nov 20, 2024

View reviewed changes

amazingphilippe added 4 commits November 20, 2024 20:57

Merge branch 'main' into fix/missing-translations

2cf461f

add missing translation

afacbc3

csv lint

b924049

Merge branch 'main' into fix/missing-translations

a2618fe

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix various translations #1997

fix various translations #1997

amazingphilippe commented Nov 15, 2024

github-actions bot commented Nov 15, 2024

andrewleith left a comment

andrewleith commented Nov 18, 2024

andrewleith left a comment

amazingphilippe Nov 18, 2024

amazingphilippe Nov 18, 2024

amazingphilippe Nov 18, 2024

amazingphilippe Nov 18, 2024

amazingphilippe Nov 18, 2024

amazingphilippe Nov 18, 2024

amazingphilippe Nov 18, 2024

amazingphilippe Nov 18, 2024

amazingphilippe Nov 18, 2024

amazingphilippe Nov 18, 2024

amazingphilippe Nov 18, 2024

amazingphilippe Nov 18, 2024

amazingphilippe Nov 20, 2024

amazingphilippe Nov 20, 2024

amazingphilippe Nov 20, 2024

amazingphilippe left a comment

fix various translations #1997

Are you sure you want to change the base?

fix various translations #1997

Conversation

amazingphilippe commented Nov 15, 2024

Summary | Résumé

Test instructions | Instructions pour tester la modification

github-actions bot commented Nov 15, 2024

🧪 Review environment

andrewleith left a comment

Choose a reason for hiding this comment

andrewleith commented Nov 18, 2024

andrewleith left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

amazingphilippe left a comment

Choose a reason for hiding this comment