Drop python 3.8 #853
Merged
Drop python 3.8 #853
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #853 +/- ##
=======================================
Coverage 91.62% 91.62%
=======================================
Files 123 123
Lines 6771 6774 +3
=======================================
+ Hits 6204 6207 +3
Misses 567 567
Flags with carried forward coverage won't be shown. Click here to find out more.
|
| @@ -3,6 +3,7 @@ | |||
| ### Deprecations | |||
| * Removed `stream_id` as an argument from `IntanRecordingInterface` [PR #794](https://github.com/catalystneuro/neuroconv/pull/794) | |||
| * The usage of `compression` and `compression_opts` directly through the `neuroconv.tools.spikeinterface` submodule are now deprecated - users should refer to the new `configure_backend` method for a general approach for setting compression. [PR #805](https://github.com/catalystneuro/neuroconv/pull/805) | |||
| * Dropped the testing of python 3.8 on the CI [PR #853](https://github.com/catalystneuro/neuroconv/pull/853) | |||
There was a problem hiding this comment.
Suggested change
| * Dropped the testing of python 3.8 on the CI [PR #853](https://github.com/catalystneuro/neuroconv/pull/853) | |
| * Dropped the testing of Python 3.8 on the CI. Dropped support for Python 3.8 in setup. [PR #853](https://github.com/catalystneuro/neuroconv/pull/853) |
| @@ -1 +1 @@ | |||
| sonpy>=1.7.1;python_version<='3.9' | |||
| sonpy>=1.7.1;python_version=='3.9' | |||
There was a problem hiding this comment.
@bendichter I don't think I have Will Collins's contact info - can you remind them of the need to release sonpy for Python >= 3.10?
CodyCBakerPhD
approved these changes
May 12, 2024
CodyCBakerPhD
added a commit
that referenced
this pull request
May 12, 2024
This reverts commit 4c8a2ca.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed on catalystneuro/roiextractors#276 (comment).