Revert "Drop python 3.8 (#853)"

This reverts commit 4c8a2ca.

.github/workflows/dev-testing.yml

@@ -23,7 +23,7 @@ jobs:
     strategy:
       fail-fast: false
       matrix:
-        python-version: ["3.9", "3.10", "3.11", "3.12"]
+        python-version: ["3.8", "3.9", "3.10", "3.11", "3.12"]
     steps:
       - uses: actions/checkout@v4
       - run: git fetch --prune --unshallow --tags

.github/workflows/doctests.yml

@@ -9,7 +9,7 @@ jobs:
     strategy:
       fail-fast: false
       matrix:
-        python-version: ["3.9", "3.10", "3.11", "3.12"]
+        python-version: ["3.8", "3.9", "3.10", "3.11", "3.12"]
         os: [ubuntu-latest, macos-13, windows-latest]
     steps:
       - uses: actions/checkout@v4

.github/workflows/formatwise-installation-testing.yml

@@ -12,7 +12,7 @@ jobs:
       fail-fast: false
       matrix:
         # Disabling these due to multiplicative nature
-        python-version: ["3.9", "3.10", "3.11", "3.12"]
+        python-version: ["3.7", "3.8", "3.9", "3.10", "3.11"]
         os: [ubuntu-latest, macos-latest, windows-latest]
         format: [ {type: recording, name: spikeglx}, {type: recording, name: edf}, {type: recording, name: intan}, {type: recording, name: neuralynx}, {type: recording, name: neuroscope}, {type: recording, name: openephys}, {type: sorting, name: cellexplorer}, {type: sorting, name: neuralynx}, {type: sorting, name: neuroscope}, {type: imaging, name: scanimage}, {type: imaging, name: tiff}, {type: behavior, name: deeplabcut} ]  # SpikeGLX is the test of the 'empty' requirements functionality - missing: ced recording gallery and video behavior gallery
     steps:

.github/workflows/live-service-testing.yml

@@ -17,7 +17,7 @@ jobs:
     strategy:
       fail-fast: false
       matrix:
-        python-version: ["3.9", "3.10", "3.11", "3.12"]
+        python-version: ["3.8", "3.9", "3.10", "3.11", "3.12"]
         os: [ubuntu-latest, macos-13, windows-latest]
     steps:
       - uses: actions/checkout@v4

.github/workflows/test-external-links.yml

@@ -16,7 +16,7 @@ jobs:
       - name: Setup Python
         uses: actions/setup-python@v5
         with:
-          python-version: "3.11"
+          python-version: "3.10"
       - name: Install package for API docs
         run: pip install .[docs]
       - name: Test External Links

.github/workflows/testing.yml

@@ -19,7 +19,7 @@ jobs:
     strategy:
       fail-fast: false
       matrix:
-        python-version: ["3.9", "3.10", "3.11", "3.12"]
+        python-version: ["3.8", "3.9", "3.10", "3.11", "3.12"]
         os: [ubuntu-latest, macos-13, windows-latest]
     steps:
       - uses: actions/checkout@v4

.github/workflows/update-s3-testing-data.yml

@@ -16,7 +16,7 @@ jobs:
       - name: Setup Python
         uses: actions/setup-python@v5
         with:
-          python-version: "3.11"
+          python-version: "3.10"
 
       - name: Setup Environment
         run: |

.readthedocs.yaml

@@ -8,7 +8,7 @@ version: 2
 build:
   os: ubuntu-22.04
   tools:
-    python: "3.11"
+    python: "3.9"
 
 # Build documentation in the docs/ directory with Sphinx
 sphinx:

CHANGELOG.md

@@ -3,7 +3,6 @@
 ### Deprecations
 * Removed `stream_id` as an argument from `IntanRecordingInterface` [PR #794](https://github.com/catalystneuro/neuroconv/pull/794)
 * The usage of `compression` and `compression_opts` directly through the `neuroconv.tools.spikeinterface` submodule are now deprecated - users should refer to the new `configure_backend` method for a general approach for setting compression. [PR #805](https://github.com/catalystneuro/neuroconv/pull/805)
- * Dropped the testing of python 3.8 on the CI [PR #853](https://github.com/catalystneuro/neuroconv/pull/853)
 
 ### Bug fixes
 * Remove JSON Schema `definitions` from the `properties` field. [PR #818](https://github.com/catalystneuro/neuroconv/pull/818)

setup.py

@@ -77,7 +77,7 @@
     packages=find_packages(where="src"),
     package_dir={"": "src"},
     include_package_data=True,  # Includes files described in MANIFEST.in in the installation.
-    python_requires=">=3.9",
+    python_requires=">=3.8",
     install_requires=install_requires,
     extras_require=extras_require,
     entry_points={

src/neuroconv/datainterfaces/ecephys/spike2/requirements.txt

@@ -1 +1 @@
-sonpy>=1.7.1;python_version=='3.9'
+sonpy>=1.7.1;python_version<='3.9'

src/neuroconv/datainterfaces/ecephys/spike2/spike2datainterface.py

@@ -9,7 +9,7 @@ def _test_sonpy_installation() -> None:
     get_package(
         package_name="sonpy",
         excluded_python_versions=["3.10", "3.11"],
-        excluded_platforms_and_python_versions=dict(darwin=dict(arm=["3.9", "3.10", "3.11", "3.12"])),
+        excluded_platforms_and_python_versions=dict(darwin=dict(arm=["3.8", "3.9", "3.10", "3.11", "3.12"])),
     )
 
 

tests/test_on_data/test_recording_interfaces.py

@@ -79,8 +79,8 @@ class TestBlackrockRecordingInterface(RecordingExtractorInterfaceTestMixin, Test
 
 
 @skipIf(
-    platform == "darwin" or this_python_version > version.parse("3.9"),
-    reason="Interface unsupported for OSX. Interface only runs on python 3.9",
+    platform == "darwin" or this_python_version < version.parse("3.8") or this_python_version > version.parse("3.9"),
+    reason="Interface unsupported for OSX. Only runs on Python 3.8 and 3.9",
 )
 class TestSpike2RecordingInterface(RecordingExtractorInterfaceTestMixin, TestCase):
     data_interface_cls = Spike2RecordingInterface