-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support Intan "one-file-per-signal" and "one-file-per-channel" formats. #791
Conversation
e3db627
to
96ec28a
Compare
With the release of neo this is ready for review. |
I thought this was a multi-file style of the format? So shouldn't there be a new interface for Intan that takes |
Good question. The file always has a header |
Oh, I see Sometimes the Other times it's just |
Changes look fine and minimal to me But what is your suggestion on release timing then? Since tests are passing, this all works with latest SI release, etc.? So we could cut a new release of NeuroConv without issue? |
Are you planning on making a release soon? I think that @alejoe91 can help us to merge SpikeInterface/spikeinterface#2833 before the next release and then we can eliminate the ceiling. |
Yes. |
Is the timeline on that in the next 2-3 weeks? It's been a while on the NeuroConv side and the GUIDE also releases in early June so would be nice to keep things synchronized |
I think the confusion is this.
I guess I will just eliminate the ceiling here but then you will have the dev tests failing. |
Thanks for clarifying; any ETA on the 'fix' that would otherwise happen on dev branch testing then? |
I am not privy to spikeinterface latest plans. I will ask Alessio next time we meet. |
As in the title. We need new releases of spikeinterface and neo for this.
Adding tests here to see if anything else is broken.
Related to issues:
#789