Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

preliminary version of standardization of the calc metrics #2880

Merged
merged 14 commits into from
Sep 25, 2023

Conversation

cmgosnell
Copy link
Member

PR Overview

Try to make both the transform and explosion step use the same frickin code to validate the calculations.

PR Checklist

  • Merge the most recent version of the branch you are merging into (probably dev).
  • All CI checks are passing. Run tests locally to debug failures
  • Make sure you've included good docstrings.
  • For major data coverage & analysis changes, run data validation tests
  • Include unit tests for new functions and classes.
  • Defensive data quality/sanity checks in analyses & data processing functions.
  • Update the release notes and reference reference the PR and related issues.
  • Do your own explanatory review of the PR to help the reviewer understand what's going on and identify issues preemptively.

Base automatically changed from explode_ferc1 to dev September 21, 2023 16:28
@cmgosnell cmgosnell marked this pull request as ready for review September 23, 2023 14:47
@codecov
Copy link

codecov bot commented Sep 23, 2023

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (4e5d603) 88.6% compared to head (80035d1) 88.5%.
Report is 3 commits behind head on dev.

Additional details and impacted files
@@           Coverage Diff           @@
##             dev   #2880     +/-   ##
=======================================
- Coverage   88.6%   88.5%   -0.1%     
=======================================
  Files         90      90             
  Lines      10833   10805     -28     
=======================================
- Hits        9600    9573     -27     
+ Misses      1233    1232      -1     
Files Coverage Δ
src/pudl/output/ferc1.py 88.7% <100.0%> (-0.6%) ⬇️
src/pudl/transform/ferc1.py 96.6% <100.0%> (+<0.1%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@zaneselvans zaneselvans linked an issue Sep 25, 2023 that may be closed by this pull request
@zaneselvans zaneselvans merged commit d71f29d into dev Sep 25, 2023
9 checks passed
@zaneselvans zaneselvans deleted the explode_calc_standardization branch September 25, 2023 23:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Create shared diagnostic tooling for XBRL calc mismatches
2 participants