Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create shared diagnostic tooling for XBRL calc mismatches #2870

Closed
1 task done
Tracked by #2871
jdangerx opened this issue Sep 20, 2023 · 3 comments · Fixed by #2880
Closed
1 task done
Tracked by #2871

Create shared diagnostic tooling for XBRL calc mismatches #2870

jdangerx opened this issue Sep 20, 2023 · 3 comments · Fixed by #2880
Assignees
Labels
ferc1 Anything having to do with FERC Form 1

Comments

@jdangerx
Copy link
Member

jdangerx commented Sep 20, 2023

We compare the calculated & reported values in our XBRL data in a few different places.

It would be nice if these comparisons could share code, though if the diagnostics differ wildly that may not be practical.

Scope

@jdangerx
Copy link
Member Author

@zaneselvans or @cmgosnell you all have a branch for this, right? Where is it at?

@jdangerx jdangerx changed the title Add diagnostic information about mismatched calculated vs. reported XBRL values Create shared diagnostic tooling for XBRL calc mismatches Sep 25, 2023
@e-belfer e-belfer moved this from Backlog to In review in Catalyst Megaproject Sep 25, 2023
@zaneselvans zaneselvans linked a pull request Sep 25, 2023 that will close this issue
8 tasks
@zaneselvans
Copy link
Member

The first part of this was under #2880 -- just getting all of the calc checks to use the same function. @cmgosnell also has #2886 but it sounds like we might be moving in another direction with getting those calculations untangled.

I'll create a new branch / PR that's linked to #2872 that tries to get new metrics in there and maybe separate the steps of the performing the calculations, checking how accurate they are, and generating the corrections.

@jdangerx
Copy link
Member Author

jdangerx commented Sep 26, 2023

I think since #2880 is merged, and the rest of the "metrics stuff" lives in #2872, we can close this issue.

@github-project-automation github-project-automation bot moved this from In review to Done in Catalyst Megaproject Sep 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ferc1 Anything having to do with FERC Form 1
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

3 participants