Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Squash XBRL explosion calculation errors #2871

Closed
3 of 4 tasks
jdangerx opened this issue Sep 20, 2023 · 0 comments
Closed
3 of 4 tasks

Squash XBRL explosion calculation errors #2871

jdangerx opened this issue Sep 20, 2023 · 0 comments
Labels
ferc1 Anything having to do with FERC Form 1 xbrl Related to the FERC XBRL transition

Comments

@jdangerx
Copy link
Member

jdangerx commented Sep 20, 2023 •
edited by zaneselvans
Loading

Right now a large portion of the inter-table calculated values do not match with the reported values. The fraction that doesn't match varies across the different collections of exploded tables:

  • balance_sheet_assets_ferc1: 85%
  • balance_sheet_liabilities_ferc1: 7%
  • income_statement_ferc1: 20%

Let's get those numbers down.

There's two parts to this: tooling/infrastructure support and actual bug identification/fixing.

These tooling things should make our bug investigation lives easier / allow us to understand whether we have successfully completed this issue.

Tooling
Beta Give feedback
  1. Create shared diagnostic tooling for XBRL calc mismatches #2870
    1 of 1
    ferc1
    cmgosnell
  2. Define XBRL explosion success metrics and measure them #2872
    0 of 4
    ferc1 testing xbrl
    cmgosnell zaneselvans

As more investigation occurs and we find more reasons that the calculations are mismatched, we should add them to this bug squashing list.

Bug squashing
Beta Give feedback
  1. Handle duplicative edges in XBRL calculation graph #2869
    0 of 5
    ferc1 xbrl
    e-belfer
@jdangerx jdangerx mentioned this issue Sep 20, 2023
Closed
@e-belfer e-belfer moved this from New to In progress in Catalyst Megaproject Sep 20, 2023
@zaneselvans zaneselvans added ferc1 Anything having to do with FERC Form 1 xbrl Related to the FERC XBRL transition labels Sep 20, 2023
zaneselvans added a commit that referenced this issue Sep 21, 2023
@zaneselvans
Merge pull request #2633 from catalyst-cooperative/explode_ferc1
be2acf0 
Having gotten Slack approval from @jdangerx @e-belfer and @cmgosnell I'm going to merge this monster into `dev` so that the changes are more widely available, especially the changes to the transform process, which should get integrated into the other FERC 2021/2022 work.

Note that the new exploded tables are not yet being written to the SQLite DB, and work on them continues. They're still experimental and we're working on reducing the calculation errors via #2871 and friends.
@github-project-automation github-project-automation bot moved this from In progress to Done in Catalyst Megaproject Aug 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
ferc1 Anything having to do with FERC Form 1 xbrl Related to the FERC XBRL transition
Projects
Catalyst Megaproject
Archived in project
Milestone
No milestone
Development

No branches or pull requests
3 participants
@zaneselvans @jdangerx @cmgosnell