Updated Notes on Anserini Build on Windows #2243
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lintool
reviewed
Nov 6, 2023
| @@ -406,4 +408,4 @@ To reproducible old results from Lucene 7.6, use [v0.5.1](https://github.com/cas | |||
|
|
|||
| This research is supported in part by the Natural Sciences and Engineering Research Council (NSERC) of Canada. | |||
| Previous support came from the U.S. National Science Foundation under IIS-1423002 and CNS-1405688. | |||
| Any opinions, findings, and conclusions or recommendations expressed do not necessarily reflect the views of the sponsors. | |||
There was a problem hiding this comment.
can you undo this change please? dunno what happened here...
lintool
reviewed
Nov 6, 2023
README.md
Outdated
| @@ -45,7 +45,9 @@ The onboarding path for Anserini starts [here](docs/start-here.md)! | |||
| <details> | |||
| <summary>Windows tips</summary> | |||
|
|
|||
| Note that on Windows, tests may fail due to encoding issues, see [#1466](https://github.com/castorini/anserini/issues/1466). | |||
| If you are using Windows, please use WSL2 to build Anserini. Please refer to the [WSL2 Installation](https://learn.microsoft.com/en-us/windows/wsl/install) document to install WSL2 if you haven't already. | |||
There was a problem hiding this comment.
we use the convention of a sentence on each line, to make the diffs more easily readable.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I tested the Anserini build on Windows with all the tests enabled on WSL2 Ubuntu with all the tests passing, and I updated notes on the Windows section of README.md to notify the users to use WSL2 if possible.