Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make Anserini and Pyserini work fully on Windows #16

Open
lintool opened this issue Nov 5, 2023 · 5 comments
Open

Make Anserini and Pyserini work fully on Windows #16

lintool opened this issue Nov 5, 2023 · 5 comments

Comments

@lintool
Copy link
Member

lintool commented Nov 5, 2023

With WSL?

Making sure tests, etc. fully pass.

@techandy42
Copy link

I will look into this.

@techandy42
Copy link

Hello @lintool, I completed the task for both Anserini and Pyserini and made the pull requests. With WSL2, all of Anserini and Pyserini builds and tests work. (Anserini: castorini/anserini#2243, Pyserini: castorini/pyserini#1705)

@techandy42
Copy link

techandy42 commented Nov 6, 2023

Hello @lintool, I reformatted my changes correctly and created new pull requests for both Anserini and Pyserini (Anserini: castorini/anserini#2245, Pyserini: castorini/pyserini#1706). The issues with the changes in the last line of the files in the previous pull-requests were because of my VS Code auto-formatting, but I got that fixed now.

@lintool
Copy link
Member Author

lintool commented Nov 6, 2023

hi @gitHubAndyLee2020 I guess with WSL, everything seems to work fine on Windows? This seems much better than cywgin... previous users have complained a lot about failing tests, etc.

Just to confirm, python -m unittest works fine with Pyserini on Windows with WSL and everything works? (i.e., all tests pass?)

@techandy42
Copy link

techandy42 commented Nov 6, 2023

Hello @lintool. Yes, everything works properly with WSL2 on Windows, including python -m unittest (all tests passed).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants