Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix TREC-COVID regressions #2196

Merged
merged 5 commits into from
Sep 18, 2023
Merged

Fix TREC-COVID regressions #2196

merged 5 commits into from
Sep 18, 2023

Conversation

lintool
Copy link
Member

@lintool lintool commented Sep 16, 2023

These regressions hadn't been run in a while - since upgrade to Lucene 9. Changed paths and tweaked expected scores.

@lintool
Copy link
Member Author

lintool commented Sep 18, 2023

Similar to #2195 - we're not able to exactly reproduce... but at least the scripts still run...

These are the commands I ran:

# https://github.com/castorini/anserini/blob/master/docs/experiments-covid.md

python src/main/python/trec-covid/download_indexes.py --date 2020-07-16 &
python src/main/python/trec-covid/download_indexes.py --date 2020-06-19 &
python src/main/python/trec-covid/download_indexes.py --date 2020-05-19 &
python src/main/python/trec-covid/download_indexes.py --date 2020-05-01 &
python src/main/python/trec-covid/download_indexes.py --date 2020-04-10 &

nohup python src/main/python/trec-covid/generate_round5_baselines.py >& logs/log.trec-covid.round5 &
nohup python src/main/python/trec-covid/generate_round4_baselines.py >& logs/log.trec-covid.round4 &
nohup python src/main/python/trec-covid/generate_round3_baselines.py >& logs/log.trec-covid.round3 &
nohup python src/main/python/trec-covid/generate_round2_baselines.py >& logs/log.trec-covid.round2 &
nohup python src/main/python/trec-covid/generate_round1_baselines.py >& logs/log.trec-covid.round1 &

# https://github.com/castorini/anserini/blob/master/docs/experiments-covid-doc2query.md

python src/main/python/trec-covid/download_doc2query_indexes.py --date 2020-07-16 &
python src/main/python/trec-covid/download_doc2query_indexes.py --date 2020-06-19 &

nohup python src/main/python/trec-covid/generate_round5_doc2query_baselines.py >& logs/log.trec-covid.round5-docTTTTTquery &
nohup python src/main/python/trec-covid/generate_round4_doc2query_baselines.py >& logs/log.trec-covid.round4-docTTTTTquery &

Copy link
Member

@ronakice ronakice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM just this question wherever such code exists

src/main/python/trec-covid/covid_baseline_tools.py Outdated Show resolved Hide resolved
@lintool lintool merged commit 88935fc into master Sep 18, 2023
1 check passed
@lintool lintool deleted the covid-fix branch September 18, 2023 23:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants