Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix TREC-COVID regressions (take 2) #2201

Merged
merged 2 commits into from
Sep 20, 2023
Merged

Fix TREC-COVID regressions (take 2) #2201

merged 2 commits into from
Sep 20, 2023

Conversation

lintool
Copy link
Member

@lintool lintool commented Sep 19, 2023

Follow up to #2196 - for whatever reason - most likely carelessness on my part - there are more effectiveness differences that I didn't capture - on the doc2query runs.

Running from scratch again to confirm:

# https://github.com/castorini/anserini/blob/master/docs/experiments-covid.md

python src/main/python/trec-covid/download_indexes.py --date 2020-07-16 &
python src/main/python/trec-covid/download_indexes.py --date 2020-06-19 &
python src/main/python/trec-covid/download_indexes.py --date 2020-05-19 &
python src/main/python/trec-covid/download_indexes.py --date 2020-05-01 &
python src/main/python/trec-covid/download_indexes.py --date 2020-04-10 &

nohup python src/main/python/trec-covid/generate_round5_baselines.py >& logs/log.trec-covid.round5 &
nohup python src/main/python/trec-covid/generate_round4_baselines.py >& logs/log.trec-covid.round4 &
nohup python src/main/python/trec-covid/generate_round3_baselines.py >& logs/log.trec-covid.round3 &
nohup python src/main/python/trec-covid/generate_round2_baselines.py >& logs/log.trec-covid.round2 &
nohup python src/main/python/trec-covid/generate_round1_baselines.py >& logs/log.trec-covid.round1 &

# https://github.com/castorini/anserini/blob/master/docs/experiments-covid-doc2query.md

python src/main/python/trec-covid/download_doc2query_indexes.py --date 2020-07-16 &
python src/main/python/trec-covid/download_doc2query_indexes.py --date 2020-06-19 &

nohup python src/main/python/trec-covid/generate_round5_doc2query_baselines.py >& logs/log.trec-covid.round5-docTTTTTquery &
nohup python src/main/python/trec-covid/generate_round4_doc2query_baselines.py >& logs/log.trec-covid.round4-docTTTTTquery &

@lintool lintool requested a review from ronakice September 19, 2023 18:17
Copy link
Member

@ronakice ronakice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@lintool
Copy link
Member Author

lintool commented Sep 19, 2023

Update: I don't think it was because I was careless... I seem to be getting some level of non-determinism in the effectiveness figures. Investigating and will report-back further.

@lintool
Copy link
Member Author

lintool commented Sep 20, 2023

False alarm. Failed regressions caused by incomplete index downloads. I've confirmed that regressions run successfully on my iMac Pro (Intel), Mac Studio (M1), tuna, and linux.cs. Going ahead to merge now.

@lintool lintool merged commit 444eacc into master Sep 20, 2023
1 check passed
@lintool lintool deleted the covid-fix2 branch September 20, 2023 02:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants