Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

40 switch from flask to fastapi #43

Merged
merged 2 commits into from
Oct 7, 2023
Merged

40 switch from flask to fastapi #43

merged 2 commits into from
Oct 7, 2023

Conversation

gcarvellas
Copy link
Contributor

Summary of changes:

  • we no longer use flask. We now use fastapi
  • all synchronous DB calls are replaced with async. There should be no reason why we need a synchronous DB call
  • the APIdocs are slightly different but they're mostly the same. Go to http://localhost:3001/docs to view
  • swagger files are not necessary so they're all removed

@gcarvellas gcarvellas linked an issue Sep 28, 2023 that may be closed by this pull request
Switch from Flask to FastAPI #40
Closed
gcarvellas
gcarvellas commented Sep 28, 2023
View reviewed changes
database/base_db.py
return cls._get_client()[MONGO_DB_NAME]

# TODO this needs to be reworked
Copy link
Contributor Author

@gcarvellas gcarvellas Sep 28, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will be done after this gets merged #41

Once that gets merged I'll make an issue to fix the approver assigning system

@gcarvellas gcarvellas added the core feature Implementing the app's basic functionality label Sep 28, 2023
@gcarvellas gcarvellas self-assigned this Sep 28, 2023
@gcarvellas gcarvellas mentioned this pull request Sep 28, 2023
Merged
Yun-L
Yun-L approved these changes Sep 29, 2023
View reviewed changes
Copy link

@Yun-L Yun-L left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tested briefly, seems to run fine

lgtm

@gcarvellas gcarvellas merged commit b4a7c4e into main Oct 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Yun-L Yun-L Yun-L approved these changes

@KevinHa48 KevinHa48 Awaiting requested review from KevinHa48

@g00gol g00gol Awaiting requested review from g00gol

Assignees

@gcarvellas gcarvellas

Labels
core feature Implementing the app's basic functionality
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Switch from Flask to FastAPI
2 participants
@gcarvellas @Yun-L