Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Switch from Flask to FastAPI #40

Closed
gcarvellas opened this issue Sep 23, 2023 · 0 comments · Fixed by #43
Closed

Switch from Flask to FastAPI #40

gcarvellas opened this issue Sep 23, 2023 · 0 comments · Fixed by #43
Assignees
@gcarvellas
Labels
core feature Implementing the app's basic functionality

Comments

@gcarvellas
Copy link
Contributor

See #30

Flask and other flask modules we use (like flask cognito and flasgger) prevent async functionality.

After some discussion with @g00gol and @Yun-L , we decided that it's best to migrate from Flask to FastAPI

FastAPI has built-in swagger documentation. We can also make our own JWT handler to replace flask cognito
@gcarvellas gcarvellas added the core feature Implementing the app's basic functionality label Sep 23, 2023
@gcarvellas gcarvellas self-assigned this Sep 23, 2023
@gcarvellas gcarvellas mentioned this issue Sep 23, 2023
Closed
@gcarvellas gcarvellas linked a pull request Sep 28, 2023 that will close this issue
40 switch from flask to fastapi #43
Merged
@g00gol g00gol mentioned this issue Oct 5, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@gcarvellas gcarvellas

Labels
core feature Implementing the app's basic functionality
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

40 switch from flask to fastapi castlepointanime/backend
1 participant
@gcarvellas