empty lat/lng as nil & unknown tag id

CHANGELOG.md

@@ -4,7 +4,7 @@
   ### Added
   - API: Allow commas for float fields [#205](https://github.com/cartoway/planner-web/pull/205)
   - Planning: Add router name to vehicle selector [#202](https://github.com/cartoway/planner-web/pull/202)
-  - Destination: Allow commas for float columns during import [#203](https://github.com/cartoway/planner-web/pull/203)
+  - Destination: Allow commas for float columns during import [#203](https://github.com/cartoway/planner-web/pull/203) & [#208](https://github.com/cartoway/planner-web/pull/208)
   - Zoning: Simplify polygons geometries [#207](https://github.com/cartoway/planner-web/pull/207)
 
   ### Changed
@@ -25,7 +25,7 @@
   - Route: Avoid unexpected stops reloading during creation [#200](https://github.com/cartoway/planner-web/pull/200)
   - Destination
     - Import: New quantities columns are immediatly usable [#203](https://github.com/cartoway/planner-web/pull/203)
-    - Import: Cumulative lines with tags were failing [#203](https://github.com/cartoway/planner-web/pull/203)
+    - Import: Cumulative lines with tags were failing [#203](https://github.com/cartoway/planner-web/pull/203) & [#208](https://github.com/cartoway/planner-web/pull/208)
     - Controller: edit params indirectly [#205](https://github.com/cartoway/planner-web/pull/205)
   - Planning: Selectors are no more resizing on click [#202](https://github.com/cartoway/planner-web/pull/202)
   - Vehicle Usage: _form was unrechable with an active device [#205](https://github.com/cartoway/planner-web/pull/205)

app/jobs/importer_destinations.rb

@@ -272,7 +272,7 @@ def prepare_tags(row, key)
         if tag.is_a?(Integer) && @tag_ids.key?(tag)
           tag
         else
-          tag = tag.strip
+          tag = tag.strip if tag.is_a?(String)
           if !@tag_labels.key?(tag)
             @tag_labels[tag] = @customer.tags.create(label: tag)
           end

lib/coerce.rb

@@ -45,6 +45,7 @@ def self.parse(str)
 
 class CoerceFloatString
   def self.parse(str)
+    str = nil if str.is_a?(String) && str.empty?
     str.gsub!(',', '.') if str.is_a?(String) && str.match(',')
     Float(str) if str
   end

test/api/v01/destinations_test.rb

@@ -215,6 +215,45 @@ def api(part = nil, param = {})
     end
   end
 
+  test 'should create bulk from json with empty strings for coords' do
+    assert_difference('Destination.count', 1) do
+      assert_difference('Visit.count', 1) do
+        assert_difference('Stop.count',
+          @customer.plannings.select{ |p| p.tags_compatible?([tags(:tag_one), tags(:tag_two)]) }.size * 1) do
+          put api(), nil, input: {
+            destinations: [{
+              name: 'Nouveau client',
+              street: nil,
+              postalcode: nil,
+              city: 'Tule',
+              state: 'Limousin',
+              lat: "",
+              lng: "",
+              detail: nil,
+              comment: nil,
+              phone_number: nil,
+              ref: 'z',
+              tags: ['tag1', 'tag2', 999],
+              geocoding_accuracy: nil,
+              foo: 'bar',
+              visits: [{
+                ref: 'v1',
+                quantities: [{deliverable_unit_id: deliverable_units(:deliverable_unit_one_one).id, quantity: 1}],
+                time_window_start_1: '08:00',
+                time_window_end_1: '12:00',
+                time_window_start_2: '14:00',
+                time_window_end_2: '18:00',
+                duration: nil
+              }]
+            }]
+          }.to_json, CONTENT_TYPE: 'application/json'
+          assert last_response.ok?, last_response.body
+          assert_equal 1, JSON.parse(last_response.body).size, 'Bad response size: ' + last_response.body.inspect
+        end
+      end
+    end
+  end
+
   test 'should create bulk from json with time exceeding one day' do
     assert_difference('Destination.count', 1) do
       assert_difference('Planning.count', 1) do