#287 Upgrade next to v15 #289
Conversation
nevendyulgerov
added
the
Type: Chore
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
…s to latest version
nevendyulgerov
force-pushed
the
feature/287-upgrade-next-to-v15
branch
from
53525bd to
7458434
Compare
| export const useElementVisibility = <T extends Element>({ | ||
| element, | ||
| export const useElementVisibility = ( | ||
| element: HTMLDivElement | null, |
There was a problem hiding this comment.
That is an odd type narrowing saying that the only element type accepted would be div elements or null. But in theory, it was supposed to accept any valid HTML element or null. I checked the code and played around, and it would take a ref typed as HTMLInputElement without any squiggly red lines (the project is using typescript 5.3.2), which causes other problems in terms of modifying that hook as the intellisense will display incorrect attributes.
I believe the element being a generic type that extends the correct ParentType is necessary. The refactoring going down one level i.e. RefObject<T> to Element does not look like a problem.
I upgraded next to
v15and react tov19for thewebapp which resulted in library upgrades in:packages/ui- upgraded thereactandtesting-libraryversionsapps/workshop- upgraded thereactandstorybookversionsI also tested the app through the docker container and didn't find any issues.