Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade Next to v15 #287

Open
5 tasks done
nevendyulgerov opened this issue Jan 2, 2025 · 1 comment · May be fixed by #289
Open
5 tasks done

Upgrade Next to v15 #287

nevendyulgerov opened this issue Jan 2, 2025 · 1 comment · May be fixed by #289
Assignees
Labels
apps: web Type: Chore Improvements to the code base and DX. It has no impact on external users e.g. Update deps

Comments

@nevendyulgerov
Copy link
Contributor

nevendyulgerov commented Jan 2, 2025

📄 Context

Next.js v15 has been released some time ago so let's test it and upgrade to it.

Please note that there are some breaking changes that will affect the app once we upgrade to v15. For example params in server components and generateMetadata are now async, while before they were not. So we'll need to handle getting those params using async/await.

📈 Subtasks

  • Upgrade to v15.
  • Fix all areas with breaking changes.
  • Generate a cartesi/rollups-explorer:devel image and use it with your cartesi-cli to check if all available functionalities/pages are working as expected

Definition of done:

  • The app is working as before.
  • Unit and e2e tests are passing as before.
@nevendyulgerov nevendyulgerov added Type: Chore Improvements to the code base and DX. It has no impact on external users e.g. Update deps apps: web labels Jan 2, 2025
@github-project-automation github-project-automation bot moved this to 📌 Todo in Explorer Unit Jan 2, 2025
@nevendyulgerov nevendyulgerov linked a pull request Jan 3, 2025 that will close this issue
@nevendyulgerov nevendyulgerov moved this from 📌 Todo to 👁 In Review in Explorer Unit Jan 3, 2025
@brunomenezes
Copy link
Collaborator

brunomenezes commented Jan 5, 2025

@nevendyulgerov, please also account for the docker images that are generated and if they are running as expected. For example, generate a cartesi/rollups-explorer:devel image and use it with your cartesi-cli to check if all available functionalities/pages are working as expected.

I think worth to add that in the subtasks as a release will kick-in an image generation to be published on docker-hub.

@nevendyulgerov nevendyulgerov self-assigned this Jan 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
apps: web Type: Chore Improvements to the code base and DX. It has no impact on external users e.g. Update deps
Projects
Status: 👁 In Review
Development

Successfully merging a pull request may close this issue.

2 participants