Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Access nominatim via osmdata and drop nominatimlite #31

Merged
merged 3 commits into from
Jun 28, 2024

Conversation

cforgaci
Copy link
Collaborator

This commit replaces nominatimlite::geo_lite_sf() with osmdata::getbb(). The former creates an issue with the workshop website deployment (error when calling nominatimlite::geo_lite_sf()) and adds a dependency that might not be needed.

@ClementineCttn, to me, it looks like getbb() leads to the same results, but maybe you tested this on other cities and it does not always work. It would be great if we could stick to getbb() from a deployment perspective. Let me know if you agree by responding to this PR.

This commit replaces `nominatimlite::geo_lite_sf()` with `osmdata::getbb()`. The former creates issues with the workshop website deployment and adds a dependency that might not be needed.
@cforgaci cforgaci added type:bug Code included in the lesson needs to be fixed type:enhancement Propose enhancement to the lesson labels Feb 18, 2024
Copy link

github-actions bot commented Feb 18, 2024

Thank you!

Thank you for your pull request 😃

🤖 This automated message can help you check the rendered files in your submission for clarity. If you have any questions, please feel free to open an issue in {sandpaper}.

If you have files that automatically render output (e.g. R Markdown), then you should check for the following:

  • 🎯 correct output
  • 🖼️ correct figures
  • ❓ new warnings
  • ‼️ new errors

Rendered Changes

🔍 Inspect the changes: https://github.com/carpentries-incubator/r-geospatial-urban/compare/md-outputs..md-outputs-PR-31

The following changes were observed in the rendered markdown documents:

 18-import-and-visualise-osm-data.md | 11 ++---------
 md5sum.txt                          |  2 +-
 2 files changed, 3 insertions(+), 10 deletions(-)
What does this mean?

If you have source files that require output and figures to be generated (e.g. R Markdown), then it is important to make sure the generated figures and output are reproducible.

This output provides a way for you to inspect the output in a diff-friendly manner so that it's easy to see the changes that occur due to new software versions or randomisation.

⏱️ Updated at 2024-05-17 16:10:00 +0000

github-actions bot pushed a commit that referenced this pull request Feb 18, 2024
github-actions bot pushed a commit that referenced this pull request May 16, 2024
github-actions bot pushed a commit that referenced this pull request May 17, 2024
@cforgaci cforgaci merged commit 7e0bbcc into main Jun 28, 2024
3 checks passed
@cforgaci cforgaci deleted the claudiu/bb-in-part4 branch June 28, 2024 22:56
github-actions bot pushed a commit that referenced this pull request Jun 28, 2024
Auto-generated via {sandpaper}
Source  : 7e0bbcc
Branch  : main
Author  : Claudiu Forgaci <[email protected]>
Time    : 2024-06-28 22:56:30 +0000
Message : Merge pull request #31 from carpentries-incubator/claudiu/bb-in-part4
github-actions bot pushed a commit that referenced this pull request Jun 28, 2024
Auto-generated via {sandpaper}
Source  : 898d8d7
Branch  : md-outputs
Author  : GitHub Actions <[email protected]>
Time    : 2024-06-28 23:14:48 +0000
Message : markdown source builds

Auto-generated via {sandpaper}
Source  : 7e0bbcc
Branch  : main
Author  : Claudiu Forgaci <[email protected]>
Time    : 2024-06-28 22:56:30 +0000
Message : Merge pull request #31 from carpentries-incubator/claudiu/bb-in-part4
github-actions bot pushed a commit that referenced this pull request Jul 2, 2024
Auto-generated via {sandpaper}
Source  : 7e0bbcc
Branch  : main
Author  : Claudiu Forgaci <[email protected]>
Time    : 2024-06-28 22:56:30 +0000
Message : Merge pull request #31 from carpentries-incubator/claudiu/bb-in-part4
github-actions bot pushed a commit that referenced this pull request Jul 2, 2024
Auto-generated via {sandpaper}
Source  : 099d6e1
Branch  : md-outputs
Author  : GitHub Actions <[email protected]>
Time    : 2024-07-02 00:41:34 +0000
Message : markdown source builds

Auto-generated via {sandpaper}
Source  : 7e0bbcc
Branch  : main
Author  : Claudiu Forgaci <[email protected]>
Time    : 2024-06-28 22:56:30 +0000
Message : Merge pull request #31 from carpentries-incubator/claudiu/bb-in-part4
github-actions bot pushed a commit that referenced this pull request Jul 9, 2024
Auto-generated via {sandpaper}
Source  : 7e0bbcc
Branch  : main
Author  : Claudiu Forgaci <[email protected]>
Time    : 2024-06-28 22:56:30 +0000
Message : Merge pull request #31 from carpentries-incubator/claudiu/bb-in-part4
github-actions bot pushed a commit that referenced this pull request Jul 9, 2024
Auto-generated via {sandpaper}
Source  : 06b0d88
Branch  : md-outputs
Author  : GitHub Actions <[email protected]>
Time    : 2024-07-09 00:42:08 +0000
Message : markdown source builds

Auto-generated via {sandpaper}
Source  : 7e0bbcc
Branch  : main
Author  : Claudiu Forgaci <[email protected]>
Time    : 2024-06-28 22:56:30 +0000
Message : Merge pull request #31 from carpentries-incubator/claudiu/bb-in-part4
github-actions bot pushed a commit that referenced this pull request Jul 16, 2024
Auto-generated via {sandpaper}
Source  : 7e0bbcc
Branch  : main
Author  : Claudiu Forgaci <[email protected]>
Time    : 2024-06-28 22:56:30 +0000
Message : Merge pull request #31 from carpentries-incubator/claudiu/bb-in-part4
github-actions bot pushed a commit that referenced this pull request Jul 16, 2024
Auto-generated via {sandpaper}
Source  : def88b9
Branch  : md-outputs
Author  : GitHub Actions <[email protected]>
Time    : 2024-07-16 00:42:50 +0000
Message : markdown source builds

Auto-generated via {sandpaper}
Source  : 7e0bbcc
Branch  : main
Author  : Claudiu Forgaci <[email protected]>
Time    : 2024-06-28 22:56:30 +0000
Message : Merge pull request #31 from carpentries-incubator/claudiu/bb-in-part4
github-actions bot pushed a commit that referenced this pull request Jul 23, 2024
Auto-generated via {sandpaper}
Source  : 7e0bbcc
Branch  : main
Author  : Claudiu Forgaci <[email protected]>
Time    : 2024-06-28 22:56:30 +0000
Message : Merge pull request #31 from carpentries-incubator/claudiu/bb-in-part4
github-actions bot pushed a commit that referenced this pull request Jul 23, 2024
Auto-generated via {sandpaper}
Source  : 12a364a
Branch  : md-outputs
Author  : GitHub Actions <[email protected]>
Time    : 2024-07-23 00:42:46 +0000
Message : markdown source builds

Auto-generated via {sandpaper}
Source  : 7e0bbcc
Branch  : main
Author  : Claudiu Forgaci <[email protected]>
Time    : 2024-06-28 22:56:30 +0000
Message : Merge pull request #31 from carpentries-incubator/claudiu/bb-in-part4
github-actions bot pushed a commit that referenced this pull request Jul 30, 2024
Auto-generated via {sandpaper}
Source  : 7e0bbcc
Branch  : main
Author  : Claudiu Forgaci <[email protected]>
Time    : 2024-06-28 22:56:30 +0000
Message : Merge pull request #31 from carpentries-incubator/claudiu/bb-in-part4
github-actions bot pushed a commit that referenced this pull request Jul 30, 2024
Auto-generated via {sandpaper}
Source  : da1ac8b
Branch  : md-outputs
Author  : GitHub Actions <[email protected]>
Time    : 2024-07-30 00:43:16 +0000
Message : markdown source builds

Auto-generated via {sandpaper}
Source  : 7e0bbcc
Branch  : main
Author  : Claudiu Forgaci <[email protected]>
Time    : 2024-06-28 22:56:30 +0000
Message : Merge pull request #31 from carpentries-incubator/claudiu/bb-in-part4
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:bug Code included in the lesson needs to be fixed type:enhancement Propose enhancement to the lesson
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant