Post feedback update lesson 4

[ClementineCttn]

Following our collective feedback on the 3rd GDCU workshop, I have amended lesson 4 mostly to make the leaflet challenge easier, to emphasize replicability and save map as images as the end of the main exercise.

[github-actions]

Thank you!

Thank you for your pull request 😃

🤖 This automated message can help you check the rendered files in your submission for clarity. If you have any questions, please feel free to open an issue in {sandpaper}.

If you have files that automatically render output (e.g. R Markdown), then you should check for the following:

• 🎯 correct output
• 🖼️ correct figures
• ❓ new warnings
• ‼️ new errors

Rendered Changes

🔍 Inspect the changes: https://github.com/carpentries-incubator/r-geospatial-urban/compare/md-outputs..md-outputs-PR-41

The following changes were observed in the rendered markdown documents:

 .DS_Store                                          | Bin 6148 -> 6148 bytes
 18-import-and-visualise-osm-data.md                |  82 ++++++++++++++++++---
 19-basic-gis-with-r-sf.md                          |  65 ++++++++--------
 4-gis-slides.html                                  |  67 ++++++++---------
 ...e-osm-data-rendered-reproducibility-1.png (new) | Bin 0 -> 75073 bytes
 ...e-osm-data-rendered-reproducibility-2.png (new) | Bin 0 -> 60216 bytes
 ...sualise-osm-data-rendered-unnamed-chunk-8-1.png | Bin 76113 -> 73520 bytes
 ...with-r-sf-rendered-unnamed-chunk-10-1.png (new) | Bin 0 -> 61756 bytes
 ...ic-gis-with-r-sf-rendered-unnamed-chunk-2-1.png | Bin 15583 -> 10950 bytes
 ...ic-gis-with-r-sf-rendered-unnamed-chunk-4-1.png | Bin 11130 -> 7462 bytes
 ...ic-gis-with-r-sf-rendered-unnamed-chunk-6-1.png | Bin 20305 -> 15887 bytes
 ...ic-gis-with-r-sf-rendered-unnamed-chunk-7-1.png | Bin 17667 -> 13009 bytes
 ...ic-gis-with-r-sf-rendered-unnamed-chunk-8-1.png | Bin 73067 -> 70399 bytes
 ...ic-gis-with-r-sf-rendered-unnamed-chunk-9-1.png | Bin 73876 -> 71288 bytes
 fig/ConservationBrielle.png (new)                  | Bin 0 -> 557050 bytes
 fig/ConservationBrielle_newrules.png (new)         | Bin 0 -> 569814 bytes
 md5sum.txt                                         |  54 +++++++-------
 17 files changed, 169 insertions(+), 99 deletions(-)

What does this mean?

If you have source files that require output and figures to be generated (e.g. R Markdown), then it is important to make sure the generated figures and output are reproducible.

This output provides a way for you to inspect the output in a diff-friendly manner so that it's easy to see the changes that occur due to new software versions or randomisation.

⏱️ Updated at 2024-05-15 13:59:14 +0000

[cforgaci]

Looks good, @ClementineCttn! I left a couple of tiny suggestions. If you process them, we can merge the PR.

[cforgaci]

@ClementineCttn before you merge this PR can you please do the checks from #7 as well?

[cforgaci]

@ClementineCttn, please consider #31 in your updates as well.

[ClementineCttn]

All of Claudiu's comment have been resolved here and in the new small PR, including the removal of nominatimlite package, naming code chunks, etc.

[cforgaci]

Looks good!