Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Basic implementation #1
Basic implementation #1
Changes from 64 commits
b0088db
71e1105
d23f3aa
7fad059
73b2b96
2f7a4c0
0fdda5a
d4e05b3
8a0bc5d
64b7580
cd20989
b1f9eb2
31c5cde
acb4593
1b03e71
825aa4c
b4bfeef
e140000
e5594d9
01e7d44
1074963
fc98c5c
f577e69
c270633
49f813c
ad228af
543054a
52ccfbf
885c15e
306af57
0f7eb64
f9ae3aa
c02217f
43e364b
a8a0f62
5129e59
967a1c3
1284066
1a32ccd
cb859c4
ff24388
ab32c58
afde289
866d9a3
c85c85e
f43f252
19f22e0
32cee0b
d959197
d85d27d
d043c9f
c42d6f6
2f38f7f
09be11b
b68ff6a
526f40c
9650963
a7799ed
fee0129
8eee93e
73cb3a2
d26cf88
16c1487
d13c2ae
7bd3d38
e63bcc8
7ea2274
52fd89b
dcbe01f
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd expect test and release to be defined in separate workflows as tests are supposed to be run with each PR created, but release only for commits on the master branch. (see ephemeral as reference)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We will pilot the use of release-please in Klyshko. Build/test and publish logic has been separated as part of this. This also computes the right labels and release names automatically.