Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Basic implementation #1

Merged
merged 69 commits into from
Mar 13, 2023
Merged

Basic implementation #1

merged 69 commits into from
Mar 13, 2023

Conversation

strieflin
Copy link
Member

This is an initial, still sketchy, implementation of Klyshko based in Golang made available to allow for early feedback. No tests at all yet.

@strieflin strieflin added the kind/feature Categorizes issue or PR as related to a new feature. label May 20, 2022
kindlich
kindlich reviewed May 21, 2022
View reviewed changes
Copy link

@kindlich kindlich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't check the license files and files that looked like they were auto-generated, I'll trust you there 😉

README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
hack/deploy.sh Show resolved Hide resolved
hack/deploy.sh Outdated Show resolved Hide resolved
hack/deploy.sh Outdated Show resolved Hide resolved
klyshko-provisioner/README.md Show resolved Hide resolved
klyshko-provisioner/hack/deploy.sh Show resolved Hide resolved
klyshko-provisioner/kii-provisioner-run.sh Outdated Show resolved Hide resolved
klyshko-provisioner/kii-provisioner-run.sh Show resolved Hide resolved
klyshko-provisioner/kii-provisioner-run.sh Show resolved Hide resolved
@strieflin
Initial commit after migration to combined repo
b0088db 
Signed-off-by: Sven Trieflinger <[email protected]>
@strieflin
Launch generator pod
71e1105 
Signed-off-by: Sven Trieflinger <[email protected]>
@strieflin
Upload tuples and track task status
d23f3aa 
Signed-off-by: Sven Trieflinger <[email protected]>
@strieflin
Rename task states to avoid name clashes
7fad059 
Signed-off-by: Sven Trieflinger <[email protected]>
@strieflin
Track job state based on task states
73b2b96 
Signed-off-by: Sven Trieflinger <[email protected]>
@strieflin
Move activation to job conroller
2f7a4c0 
Signed-off-by: Sven Trieflinger <[email protected]>
@strieflin
Use compliant base images from carbynestack/base-images
0fdda5a 
Signed-off-by: Sven Trieflinger <[email protected]>
@strieflin
Fix build issues resulting from deprecation of insecure schemes by Gi…
d4e05b3 
…tHub

Signed-off-by: Sven Trieflinger <[email protected]>
@strieflin
Compute prng seed from md5sum of job id
8a0bc5d 
Signed-off-by: Sven Trieflinger <[email protected]>
@strieflin
Add pre-commit configuration
64b7580 
Signed-off-by: Sven Trieflinger <[email protected]>
@strieflin
Add basic scheduler
cd20989 
Signed-off-by: Sven Trieflinger <[email protected]>
@strieflin
Add SBOM creation script and 3rd party licenses
b1f9eb2 
Signed-off-by: Sven Trieflinger <[email protected]>
@strieflin
Use latest CLI version in provisioner
31c5cde 
Signed-off-by: Sven Trieflinger <[email protected]>
@strieflin
Add readme for fake-offline crg
acb4593 
Signed-off-by: Sven Trieflinger <[email protected]>
@strieflin
Move deploy scripts to hack folder
1b03e71 
Signed-off-by: Sven Trieflinger <[email protected]>
@strieflin
Add architecture and usage instructions to README
825aa4c 
Signed-off-by: Sven Trieflinger <[email protected]>
@strieflin
Update copyright headers
b4bfeef 
Signed-off-by: Sven Trieflinger <[email protected]>
@strieflin
Add copyright headers to sample manifests
e140000 
Signed-off-by: Sven Trieflinger <[email protected]>
@strieflin
Change type for count property of job
e5594d9 
Signed-off-by: Sven Trieflinger <[email protected]>
@strieflin
Add README to provisioner
01e7d44 
Signed-off-by: Sven Trieflinger <[email protected]>
@strieflin
Add / revise READMEs in submodules
1074963 
Signed-off-by: Sven Trieflinger <[email protected]>
@strieflin
Use compliant base image in fake CRG, fix bugs in KII implementation
fc98c5c 
Signed-off-by: Sven Trieflinger <[email protected]>
@strieflin
Include AUTHORS files when collecting 3rd party license information
f577e69 
Signed-off-by: Sven Trieflinger <[email protected]>
@strieflin
Add license header to .gitignore
c270633 
Signed-off-by: Sven Trieflinger <[email protected]>
@strieflin
Add Codacy badge
49f813c 
Signed-off-by: Sven Trieflinger <[email protected]>
@strieflin
Fix first batch of SCA findings
ad228af 
Signed-off-by: Sven Trieflinger <[email protected]>
@strieflin
Copy link
Member Author

Fixes #5.

@strieflin strieflin mentioned this pull request Dec 21, 2022
Closed
@strieflin strieflin mentioned this pull request Jan 27, 2023
Closed
9 tasks
sbckr
sbckr requested changes Mar 7, 2023
View reviewed changes
Copy link
Member

@sbckr sbckr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would expect the basic implementation to also provide a workflow configuration to create github releases, e.g., as provided with ephemeral/.github/workflows/publish-and-release.yaml, as well as an auto labeler and stale issue cleanup configuration.
❗ Especially important is the part which collects and bundles the 3rd-party license information.

Please also note the comments in the files.

README.md Outdated Show resolved Hide resolved
.github/workflows/operator.yaml Outdated
key: ${{ runner.os }}-go-${{ hashFiles('**/go.sum') }}
restore-keys: |
${{ runner.os }}-go-
- name: Build and Test
Copy link
Member

@sbckr sbckr Mar 3, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd expect test and release to be defined in separate workflows as tests are supposed to be run with each PR created, but release only for commits on the master branch. (see ephemeral as reference)

Copy link
Member Author

@strieflin strieflin Mar 11, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We will pilot the use of release-please in Klyshko. Build/test and publish logic has been separated as part of this. This also computes the right labels and release names automatically.

README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Show resolved Hide resolved
klyshko-operator/controllers/tuplegenerationscheduler_controller.go Show resolved Hide resolved
klyshko-operator/controllers/tuplegenerationscheduler_controller.go Show resolved Hide resolved
klyshko-operator/controllers/tuplegenerationscheduler_controller.go Show resolved Hide resolved
klyshko-operator/controllers/tuplegenerationscheduler_controller.go Show resolved Hide resolved
klyshko-operator/controllers/tuplegenerationtask_controller.go Show resolved Hide resolved
@sbckr sbckr mentioned this pull request Mar 7, 2023
Merged
@strieflin
Copy link
Member Author

Workflows for auto labelling and stale issue handling have been added.

@strieflin strieflin force-pushed the basic-implementation branch 3 times, most recently from 3021818 to aeeb0f3 Compare March 7, 2023 15:32
@strieflin
Address review comments
7bd3d38 
Signed-off-by: Sven Trieflinger <[email protected]>
@strieflin
Copy link
Member Author

Workflows for auto labelling and stale issue handling have been added.

These have been removed again as they are available in master already.

@strieflin strieflin requested a review from sbckr March 11, 2023 09:25
@strieflin strieflin marked this pull request as ready for review March 11, 2023 09:26
sbckr
sbckr approved these changes Mar 13, 2023
View reviewed changes
Copy link
Member

@sbckr sbckr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sbckr sbckr merged commit b4da582 into master Mar 13, 2023
@sbckr sbckr deleted the basic-implementation branch March 13, 2023 10:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kindlich kindlich kindlich left review comments

@sbckr sbckr sbckr approved these changes

Assignees
No one assigned
Labels
kind/feature Categorizes issue or PR as related to a new feature. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@strieflin @kindlich @sbckr