Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(side-panel): refactor to match latest ibm-products #11511

Merged
merged 12 commits into from
Feb 16, 2024
Merged

fix(side-panel): refactor to match latest ibm-products #11511

merged 12 commits into from
Feb 16, 2024

Conversation

lee-chase
Copy link
Member

Related Ticket(s)

carbon-design-system/ibm-products#4141

Description

Updates structure of SidePanel following restructure of @carbon/ibm-products SidePanel. This simplifies the HTML structure and title scroll animation.

Changelog

Changed

  • packages/carbon-web-components/src/components/side-panel/side-panel.scss
  • packages/carbon-web-components/src/components/side-panel/side-panel.ts

@lee-chase lee-chase requested a review from a team as a code owner February 9, 2024 11:24
@lee-chase lee-chase requested review from emyarod and ariellalgilmore and removed request for a team February 9, 2024 11:24
@ibmdotcom-bot
Copy link
Contributor

ibmdotcom-bot commented Feb 9, 2024 •
edited
Loading

Deploy preview created for package Web Components HTML Test Application:
https://ibmdotcom-web-components-html-test-upstream.s3.us-east.cloud-object-storage.appdomain.cloud/deploy-previews/11511/index.html

Built with commit: 26fe8e3028d02ceb2fbb5cd9e237b54e3d401679

@ibmdotcom-bot
Copy link
Contributor

ibmdotcom-bot commented Feb 9, 2024 •
edited
Loading

Deploy preview created for package Carbon Web Components:
https://carbon-web-components.s3.us-east.cloud-object-storage.appdomain.cloud/deploy-previews/11511/index.html

Built with commit: 26fe8e3028d02ceb2fbb5cd9e237b54e3d401679

@ibmdotcom-bot
Copy link
Contributor

ibmdotcom-bot commented Feb 9, 2024 •
edited
Loading

Deploy preview created for package Web Components:
https://ibmdotcom-webcomponents.s3.us-east.cloud-object-storage.appdomain.cloud/deploy-previews/11511/index.html

Built with commit: 26fe8e3028d02ceb2fbb5cd9e237b54e3d401679

@ibmdotcom-bot
Copy link
Contributor

ibmdotcom-bot commented Feb 9, 2024 •
edited
Loading

Deploy preview created for package Web Components (React wrapper):
https://ibmdotcom-web-components-react.s3-web.us-east.cloud-object-storage.appdomain.cloud/deploy-previews/11511/index.html

Built with commit: 26fe8e3028d02ceb2fbb5cd9e237b54e3d401679

@ariellalgilmore ariellalgilmore changed the title fix: refactor side-panel to match latest ibm-products fix(side-panel): refactor to match latest ibm-products Feb 13, 2024
ariellalgilmore
ariellalgilmore approved these changes Feb 13, 2024
View reviewed changes
Copy link
Member

@ariellalgilmore ariellalgilmore left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! just minor adjustments

packages/carbon-web-components/src/components/side-panel/side-panel.scss Outdated Show resolved Hide resolved
packages/carbon-web-components/src/components/side-panel/side-panel.scss Outdated Show resolved Hide resolved
@lee-chase
Copy link
Member Author

@ariellalgilmore corrections made, there were a few 'cds-' now replaced.

@ariellalgilmore ariellalgilmore added the Ready to merge Label for the pull requests that are ready to merge label Feb 14, 2024
@kodiakhq kodiakhq bot merged commit 51e021a into carbon-design-system:main Feb 16, 2024
12 of 20 checks passed
@kennylam kennylam mentioned this pull request Mar 13, 2024
Open
kennylam pushed a commit to kennylam/carbon-for-ibm-dotcom that referenced this pull request Jun 11, 2024
@lee-chase
fix(side-panel): refactor to match latest ibm-products (carbon-design…
aaa9bd7 
…-system#11511)

### Related Ticket(s)

carbon-design-system/ibm-products#4141

### Description

Updates structure of SidePanel following restructure of @carbon/ibm-products SidePanel. This simplifies the HTML structure and title scroll animation.

### Changelog

**Changed**

- packages/carbon-web-components/src/components/side-panel/side-panel.scss
- packages/carbon-web-components/src/components/side-panel/side-panel.ts
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ariellalgilmore ariellalgilmore ariellalgilmore approved these changes

@emyarod emyarod Awaiting requested review from emyarod emyarod is a code owner automatically assigned from carbon-design-system/carbon-for-ibm-com-members

Assignees

@IgnacioBecerra IgnacioBecerra

Labels
Ready to merge Label for the pull requests that are ready to merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@lee-chase @ibmdotcom-bot @ariellalgilmore @IgnacioBecerra