Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix(checkbox): a11y issue v1 #11439

Merged
merged 1 commit into from
Jan 23, 2024
Merged

Fix(checkbox): a11y issue v1 #11439

merged 1 commit into from
Jan 23, 2024

Conversation

sangeethababu9223
Copy link
Member

Related Ticket(s)

Closes #11345

Description

Accessibility issue on checkbox:
The ARIA attributes aria-checked are not valid for the element with implicit ARIA role "checkbox"

Changelog

Removed

  • Removed aria-checked attribute from the input field.

@sangeethababu9223 sangeethababu9223 requested a review from a team as a code owner January 23, 2024 12:59
@ibmdotcom-bot
Copy link
Contributor

Deploy preview created for package Web Components HTML Test Application:
https://ibmdotcom-web-components-html-test-upstream.s3.us-east.cloud-object-storage.appdomain.cloud/deploy-previews/11439/index.html

Built with commit: 6bef041895c801e55f0a40ef877e1a970128a54d

@ibmdotcom-bot
Copy link
Contributor

Deploy preview created for package React:
https://ibmdotcom-react.s3.us-south.cloud-object-storage.appdomain.cloud/deploy-previews/11439/index.html

Built with commit: 6bef041895c801e55f0a40ef877e1a970128a54d

@ibmdotcom-bot
Copy link
Contributor

Deploy preview created for package Carbon Web Components:
https://carbon-web-components.s3.us-east.cloud-object-storage.appdomain.cloud/deploy-previews/11439/index.html

Built with commit: 6bef041895c801e55f0a40ef877e1a970128a54d

@ibmdotcom-bot
Copy link
Contributor

Deploy preview created for package Web Components (React wrapper):
https://ibmdotcom-web-components-react.s3-web.us-east.cloud-object-storage.appdomain.cloud/deploy-previews/11439/index.html

Built with commit: 6bef041895c801e55f0a40ef877e1a970128a54d

@ibmdotcom-bot
Copy link
Contributor

Deploy preview created for package Web Components:
https://ibmdotcom-webcomponents.s3.us-east.cloud-object-storage.appdomain.cloud/deploy-previews/11439/index.html

Built with commit: 6bef041895c801e55f0a40ef877e1a970128a54d

kennylam
kennylam approved these changes Jan 23, 2024
View reviewed changes
Copy link
Member

@kennylam kennylam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@kennylam kennylam added the Ready to merge Label for the pull requests that are ready to merge label Jan 23, 2024
@kodiakhq kodiakhq bot merged commit 0d72fc9 into carbon-design-system:v1 Jan 23, 2024
28 of 30 checks passed
@sangeethababu9223 sangeethababu9223 linked an issue Jan 23, 2024 that may be closed by this pull request
[Accessibility]: accessibility issue on checkbox #11345
Closed
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kennylam kennylam kennylam approved these changes

@emyarod emyarod Awaiting requested review from emyarod emyarod is a code owner automatically assigned from carbon-design-system/carbon-for-ibm-com-members

@annawen1 annawen1 Awaiting requested review from annawen1 annawen1 is a code owner automatically assigned from carbon-design-system/carbon-for-ibm-com-members

Assignees
No one assigned
Labels
accessibility Has accessibility requirement package: carbon web components Ready to merge Label for the pull requests that are ready to merge v1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Accessibility]: accessibility issue on checkbox
3 participants
@sangeethababu9223 @ibmdotcom-bot @kennylam