Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Accessibility]: accessibility issue on checkbox #11345

Closed
2 tasks done
cedricpelle opened this issue Jan 8, 2024 · 0 comments · Fixed by #11439
Closed
2 tasks done

[Accessibility]: accessibility issue on checkbox #11345

cedricpelle opened this issue Jan 8, 2024 · 0 comments · Fixed by #11439
Assignees
@sangeethababu9223
Labels
accessibility Has accessibility requirement bug Something isn't working dev Needs some dev work package: carbon web components

Comments

@cedricpelle
Copy link

Description

Accessibility issue on chexkbox.

image

Accessibility_Report-carbon-web-components example - checkbox.xlsx

Component(s) impacted

checkbox
https://web-components-v1.carbondesignsystem.com/?path=/docs/components-checkbox--default

Browser

No response

Carbon for IBM.com version

v1.35

Severity

Severity 2 = Aspects of design is broken, and impedes users in a significant way, but there is a way to complete their tasks. Affects major functionality, has a workaround.

Application/website

IBM terms

Package

@carbon/ibmdotcom-web-components, @carbon/web-components

CodeSandbox example

https://codesandbox.io/p/devbox/carbon-web-components-checkbox-example-eh36kw

Steps to reproduce the issue (if applicable)

test-carbon.zip

Release date (if applicable)

No response

Code of Conduct
@cedricpelle cedricpelle added bug Something isn't working dev Needs some dev work labels Jan 8, 2024
@kennylam kennylam moved this to Backlog in Carbon for IBM.com Jan 22, 2024
@sangeethababu9223 sangeethababu9223 self-assigned this Jan 23, 2024
@sangeethababu9223 sangeethababu9223 mentioned this issue Jan 23, 2024
Merged
@sangeethababu9223 sangeethababu9223 moved this from Backlog to Review in Carbon for IBM.com Jan 23, 2024
kodiakhq bot pushed a commit that referenced this issue Jan 23, 2024
@sangeethababu9223
Fix(checkbox): a11y issue v1 (#11439)
0d72fc9 
### Related Ticket(s)

Closes #11345

### Description

Accessibility issue on checkbox:
The ARIA attributes `aria-checked` are not valid for the element <input> with implicit ARIA role "checkbox"


### Changelog

**Removed**

- Removed `aria-checked` attribute from the input field.

<!-- React and Web Component deploy previews are enabled by default. -->
<!-- To enable additional available deploy previews, apply the following -->
<!-- labels for the corresponding package: -->
<!-- *** "test: e2e": Codesandbox examples and e2e integration tests -->
<!-- *** "package: services": Services -->
<!-- *** "package: utilities": Utilities -->
<!-- *** "RTL": React / Web Components (RTL) -->
<!-- *** "feature flag": React / Web Components (experimental) -->
@sangeethababu9223 sangeethababu9223 linked a pull request Jan 23, 2024 that will close this issue
Fix(checkbox): a11y issue v1 #11439
Merged
@sangeethababu9223 sangeethababu9223 moved this from Review to Done in Carbon for IBM.com Jan 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sangeethababu9223 sangeethababu9223

Labels
accessibility Has accessibility requirement bug Something isn't working dev Needs some dev work package: carbon web components
Projects
Carbon for IBM.com
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix(checkbox): a11y issue v1 sangeethababu9223/carbon-for-ibm-dotcom
3 participants
@kennylam @cedricpelle @sangeethababu9223