Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(masthead-a11y): navigation role do not have unique labels #10881

Merged
merged 11 commits into from
Oct 25, 2023
Merged

fix(masthead-a11y): navigation role do not have unique labels #10881

merged 11 commits into from
Oct 25, 2023

Conversation

sangeethababu9223
Copy link
Member

Related Ticket(s)

Closes #9680

Description

Multiple elements with navigation role do not have unique labels

Changelog

New

  • Added aria-label to nav in Masthead L1 for both react and web components

@sangeethababu9223 sangeethababu9223 requested a review from a team as a code owner August 25, 2023 14:59
@ibmdotcom-bot
Copy link
Contributor

ibmdotcom-bot commented Aug 25, 2023 •
edited
Loading

Deploy preview created for package React:
https://ibmdotcom-react.s3.us-south.cloud-object-storage.appdomain.cloud/deploy-previews/10881/index.html

Built with commit: 9e9c785217df7da12d679f8f694117190c1f9e41

@ibmdotcom-bot
Copy link
Contributor

ibmdotcom-bot commented Aug 25, 2023 •
edited
Loading

Deploy preview created for package Carbon Web Components:
https://carbon-web-components.s3.us-east.cloud-object-storage.appdomain.cloud/deploy-previews/10881/index.html

Built with commit: 9e9c785217df7da12d679f8f694117190c1f9e41

@ibmdotcom-bot
Copy link
Contributor

ibmdotcom-bot commented Aug 25, 2023 •
edited
Loading

Deploy preview created for package Web Components (React wrapper):
https://ibmdotcom-web-components-react.s3-web.us-east.cloud-object-storage.appdomain.cloud/deploy-previews/10881/index.html

Built with commit: 9e9c785217df7da12d679f8f694117190c1f9e41

@ibmdotcom-bot
Copy link
Contributor

ibmdotcom-bot commented Aug 25, 2023 •
edited
Loading

Deploy preview created for package Web Components:
https://ibmdotcom-webcomponents.s3.us-east.cloud-object-storage.appdomain.cloud/deploy-previews/10881/index.html

Built with commit: 9e9c785217df7da12d679f8f694117190c1f9e41

annawen1
annawen1 reviewed Aug 30, 2023
View reviewed changes
Copy link
Member

@annawen1 annawen1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Looks like there's some format error - you can run yarn format in the root of the project and it will re-format any files it's complaining about

Screenshot 2023-08-30 at 9 20 51 AM

@IgnacioBecerra IgnacioBecerra added package: react Work necessary for the Carbon for IBM.com react components package package: web components Work necessary for the IBM.com Library web components package Ready to merge Label for the pull requests that are ready to merge labels Oct 9, 2023
@ibmdotcom-bot
Copy link
Contributor

ibmdotcom-bot commented Oct 10, 2023 •
edited
Loading

Deploy preview created for package Web Components HTML Test Application:
https://ibmdotcom-web-components-html-test-upstream.s3.us-east.cloud-object-storage.appdomain.cloud/deploy-previews/10881/index.html

Built with commit: 9e9c785217df7da12d679f8f694117190c1f9e41

@kennylam
Copy link
Member

@sangeethababu9223 Looks like you need to update the snapshots.

@ariellalgilmore
Copy link
Member

the ci-checks are failing due to a test failing in packages/carbon-web-components, but not effected by this PR. Will merge this PR through

@ariellalgilmore ariellalgilmore merged commit 2c9d0ab into carbon-design-system:main Oct 25, 2023
8 of 11 checks passed
kennylam added a commit that referenced this pull request Oct 28, 2023
@sangeethababu9223 @annawen1
@IgnacioBecerra @kennylam @ariellalgilmore
fix(masthead-a11y): navigation role do not have unique labels (#10881)
671af71 
* fix(masthead-a11y):navigation unique labels

* fix(masthead-a11y): navigation role do not have unique labels format

---------

Co-authored-by: Anna Wen <[email protected]>
Co-authored-by: Ignacio Becerra <[email protected]>
Co-authored-by: kennylam <[email protected]>
Co-authored-by: Ariella Gilmore <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@annawen1 annawen1 annawen1 left review comments

@IgnacioBecerra IgnacioBecerra IgnacioBecerra approved these changes

@ariellalgilmore ariellalgilmore Awaiting requested review from ariellalgilmore ariellalgilmore is a code owner automatically assigned from carbon-design-system/carbon-for-ibm-com-members

Assignees
No one assigned
Labels
package: react Work necessary for the Carbon for IBM.com react components package package: web components Work necessary for the IBM.com Library web components package Ready to merge Label for the pull requests that are ready to merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Masthead A11Y]: Multiple elements with "navigation" role do not have unique labels
6 participants
@sangeethababu9223 @ibmdotcom-bot @kennylam @ariellalgilmore @IgnacioBecerra @annawen1