Skip to content

Commit

Permalink
fix(masthead-a11y): navigation role do not have unique labels (#10881)
Browse files Browse the repository at this point in the history
* fix(masthead-a11y):navigation unique labels

* fix(masthead-a11y): navigation role do not have unique labels format

---------

Co-authored-by: Anna Wen <[email protected]>
Co-authored-by: Ignacio Becerra <[email protected]>
Co-authored-by: kennylam <[email protected]>
Co-authored-by: Ariella Gilmore <[email protected]>
  • Loading branch information
5 people committed Oct 28, 2023
1 parent 4002bf4 commit 671af71
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 2 deletions.
2 changes: 1 addition & 1 deletion packages/react/src/components/Masthead/MastheadL1.js
Original file line number Diff line number Diff line change
Expand Up @@ -83,7 +83,7 @@ const MastheadL1 = ({ navigationL1, ...rest }) => {
<HeaderNavContainer>
<HeaderNavigation
className={`${prefix}--masthead__l1-nav`}
aria-label="">
aria-label="Main Navigation">
{mastheadL1Links}
</HeaderNavigation>
</HeaderNavContainer>
Expand Down
5 changes: 4 additions & 1 deletion packages/web-components/src/components/masthead/top-nav.ts
Original file line number Diff line number Diff line change
Expand Up @@ -595,7 +595,10 @@ class DDSTopNav extends StableSelectorMixin(HostListenerMixin(BXHeaderNav)) {
</div>
<div class="${ddsPrefix}-ce--header__nav-content-container">
<div class="${prefix}--header__nav-content">
<nav part="nav" class="${prefix}--header__nav">
<nav
part="nav"
class="${prefix}--header__nav"
aria-label="Main Navigation">
<div class="${prefix}--sub-content-left"></div>
<div
part="menubar"
Expand Down

0 comments on commit 671af71

Please sign in to comment.