feat(next): upgrade to v11 #62
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # package.json # yarn.lock
|
Deploy preview created: Built with commit: 8fe2dc9d1fa9e87470d1f5bb385753c2f2807831 |
|
We've marked this issue as stale because there hasn't been any activity for 60 days. If there's no further activity on this issue in the next three days then we'll close it. You can keep the conversation going with just a short comment. Thanks for your contributions. |
|
Closing, Next v12 might actually work better... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Ticket(s)
Refs #57
Description
This PR upgrades NextJS to v11. This is in draft for now, as it currently has one open question in regards to how it should handle styles, considering that the previous approach with Next v10 allowed for
scssimports on a per-page level. NextJS v11 enforces the use of CSS modules, otherwise regularscssimports can only happen in_app.js:https://nextjs.org/docs/messages/css-global
Carbon for IBM.comcurrently is not designed to handle CSS modules, as it is on Carbon v10. This leaves a gap in how component level styling can be handled without stuffing the base page with all of the necessary styles.Will have to leave in draft for now until a better solution can be thought of in the meantime, but wanted to have this open to show the current state of the upgrade.
There is also currently a discussion about allowing for global CSS, which would help as
Carbon for IBM.comis technically considered a 3rd party library in this scenario: vercel/next.js#27953Changelog
Changed
nextto v11reactto v17Removed
next.config.js