Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[NextJS Template] Investigate upgrade to NextJS 11 #57

Open
jeffchew opened this issue Jun 17, 2021 · 2 comments
Open

[NextJS Template] Investigate upgrade to NextJS 11 #57

jeffchew opened this issue Jun 17, 2021 · 2 comments
Assignees
Labels
dev Needs some dev work Feature request A new adopter requested feature icebox used for all issues in the Icebox pipeline. Stalebot ignores these issues when this label is added. priority: medium

Comments

@jeffchew
Copy link
Member

jeffchew commented Jun 17, 2021

The problem

More users may be interested in taking advantage of the latest version of NextJS when starting a new project with Carbon for IBM.com. It was just announced that NextJS 11 has been released:

https://nextjs.org/blog/next-11

The solution

Upgrade the NextJS template to v11

Additional information

@jeffchew jeffchew added Feature request A new adopter requested feature dev Needs some dev work labels Jun 17, 2021
@jeffchew jeffchew added this to the Sprint 21-15 milestone Jun 29, 2021
@jeffchew jeffchew modified the milestones: Sprint 21-15, Sprint 21-16 Jul 13, 2021
@jeffchew jeffchew self-assigned this Aug 2, 2021
@jeffchew
Copy link
Member Author

Fortunately we are able to leverage a lot more out-of-the-box functionality in NextJS 11. However, one of the questions that has come up now is how to handle non-global CSS imports, as currently those are being pulled in on the page level. The recommendation from NextJS team is to move to CSS modules. Will discuss with the team on the next steps and what this would look like when upgrading.

@jeffchew jeffchew removed this from the Sprint 21-17 milestone Aug 19, 2021
@jeffchew jeffchew added the icebox used for all issues in the Icebox pipeline. Stalebot ignores these issues when this label is added. label Aug 19, 2021
@jeffchew
Copy link
Member Author

jeffchew commented Aug 19, 2021

This is iceboxed for now, as currently the blocker is the ability to pull in global css files outside of _app.js, as Carbon for IBM.com is technically considered 3rd party and is not designed to be ingested as CSS modules currently:

https://nextjs.org/docs/messages/css-global

A draft PR has been opened with most of the work completed: #62

There is also currently a discussion about allowing for global CSS, which would help as Carbon for IBM.com is technically considered a 3rd party library in this scenario: vercel/next.js#27953

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dev Needs some dev work Feature request A new adopter requested feature icebox used for all issues in the Icebox pipeline. Stalebot ignores these issues when this label is added. priority: medium
Projects
None yet
Development

No branches or pull requests

2 participants