Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ros2-jazzy #49

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Add ros2-jazzy #49

wants to merge 2 commits into from

Conversation

artivis
Copy link
Contributor

@artivis artivis commented May 17, 2024

This PR adds a blueprint to setup a ROS 2 Jazzy environment (which is based on 24.04).

It is analogous to #29.

Signed-off-by: artivis <[email protected]>
@townsend2010
Copy link
Contributor

Hey @artivis,

Thanks for this!

I think we discussed this previously with the ROS and ROS2 Blueprints, but we really don't want to have a bunch of similar Blueprints available. We really need a strategy that can have something like "sub-Blueprints", but we aren't there yet. For now, I think no more than 2 similar Blueprints at the same time will make it less confusing for users. These Blueprints show up for everyone and users not familiar with what ROS is will be confused by ros-noetic, ros2-humble, and if we were to take this, ros2-jazzy.

Is it still important to have ros2-humble? I ask because perhaps we can remove that one in favor of this one.

@artivis
Copy link
Contributor Author

artivis commented May 17, 2024

Hi @townsend2010,

I get your point.

Let me start by saying that those blueprints shouldn't be confusing for the targeted audience. The ROS project follows the same release cycle as Ubuntu. As such they have an LTS release based on each Ubuntu LTS. This new blueprint, jazzy, is the new ROS 2 LTS based on 24.04. As such it cannot really replace humble which is based on 22.04. Similarly noetic is the ROS 1 LTS release based on 20.04. They are not interchangeable and each have a user base.

So I guess at this point it's either a matter of figuring out a mechanism of sort (such as the sub-Blueprints you mention) or deciding to intentionally dropping support for one (or several) Ubuntu release(s). Keeping in mind that, e.g., noetic will phase out once multipass stop supporting 20.04 etc.

@townsend2010
Copy link
Contributor

Hey @artivis,

Let me start by saying that those blueprints shouldn't be confusing for the targeted audience.
For sure. What I'm concerned about is all of the other users. I can imagine a scenario where users not familiar with what ROS is sees a bunch of these in multipass find and then think these must be very important (which they are to the targeted audience) since there are so many of them. Then they launch them and then wonder what they re supposed to do. This whole UX needs to be solved, but that is for another day.

Until we are at that point, my opinion is that we should only have two of these, but ideally this is a product decision. Unfortunately, we have no PM, so we are kind of stuck and need to make our best guess:)

Signed-off-by: artivis <[email protected]>
@artivis artivis mentioned this pull request Jun 11, 2024
@artivis
Copy link
Contributor Author

artivis commented Jun 11, 2024

As discussed, #56 removes the ROS Noetic blueprint in favor of this one.

@ricab
Copy link
Collaborator

ricab commented Jun 11, 2024

Thank you @artivis, we'll have this reviewed soon.

@georgeliao
Copy link
Contributor

Hi @artivis
Thanks for this. I have tested the blueprint. It worked well on Linux. However, about merging it, because it uses image 24.04, I think we need to wait for the multipass 1.14 release, see #53 for details. @ricab, shall we keep the PR like this and just approve it? Same goes to #56.

@artivis
Copy link
Contributor Author

artivis commented Jun 11, 2024

@georgeliao Thanks for the feedback.
That's perfectly fine with me 👍

@ricab
Copy link
Collaborator

ricab commented Jun 11, 2024

Yup, that sounds good @georgeliao, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants