Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(emitter): decouple message emitter and printer #300

Draft
wants to merge 4 commits into
base: poc/cli-to-cli-protocol
Choose a base branch
from
Draft

feat(emitter): decouple message emitter and printer #300

wants to merge 4 commits into from

Commits on Nov 4, 2024

  1. feat(emitter): decouple message emitter and printer 

    Introduce a common protocol that sits between message emitters and the
screen printer and log handler, as the first step to allow the local
system to listen for remotely emitted messages. This is intended to be
used for emitter message streaming from managed instances.

Signed-off-by: Claudio Matsuoka <[email protected]>
    @cmatsuoka
    cmatsuoka committed Nov 4, 2024
    Configuration menu
    Copy the full SHA
    96ad550 View commit details
    Browse the repository at this point in the history

  2. feat(emitter): also decouple captured message streaming 

    Note that server side handling of captured messages will be done by
the emitter and not the printer.

Signed-off-by: Claudio Matsuoka <[email protected]>
    @cmatsuoka
    cmatsuoka committed Nov 4, 2024
    Configuration menu
    Copy the full SHA
    ab23abe View commit details
    Browse the repository at this point in the history

  3. chore: address linter warnings 

    Signed-off-by: Claudio Matsuoka <[email protected]>
    @cmatsuoka
    cmatsuoka committed Nov 4, 2024
    Configuration menu
    Copy the full SHA
    6e63af0 View commit details
    Browse the repository at this point in the history

Commits on Nov 6, 2024

  1. refactor: make emitter message handler public 

    Signed-off-by: Claudio Matsuoka <[email protected]>
    @cmatsuoka
    cmatsuoka committed Nov 6, 2024
    Configuration menu
    Copy the full SHA
    3a5a613 View commit details
    Browse the repository at this point in the history