feat(emitter): decouple message emitter and printer #300
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Introduce a common protocol that sits between message emitters and the screen printer and log handler, as the first step to allow the local system to listen for remotely emitted messages. This is intended to be used for emitter message streaming from managed instances. Signed-off-by: Claudio Matsuoka <[email protected]>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## feature/cli-to-cli-protocol #300 +/- ##
==============================================================
Coverage ? 93.86%
==============================================================
Files ? 7
Lines ? 1238
Branches ? 244
==============================================================
Hits ? 1162
Misses ? 68
Partials ? 8 ☔ View full report in Codecov by Sentry. |
Note that server side handling of captured messages will be done by the emitter and not the printer. Signed-off-by: Claudio Matsuoka <[email protected]>
Signed-off-by: Claudio Matsuoka <[email protected]>
Signed-off-by: Claudio Matsuoka <[email protected]>
cmatsuoka
changed the base branch from
feature/cli-to-cli-protocol
to
poc/cli-to-cli-protocol
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduce a common protocol that sits between message emitters and the
screen printer and log handler, as the first step to allow the local
system to listen for remotely emitted messages. This is intended to be
used for emitter message streaming from managed instances.
Signed-off-by: Claudio Matsuoka [email protected]
tox?