tests: add proxy option to test file for driver #103
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding a proxy option to the driver/test_kubeflow_workloads.py script, will allow users to tell the driver it will run in a proxied environment. With this, a PodDefault will be used for setting environment variables (NO_PROXY, HTTP_PROXY, HTTPS_PROXY) in the Pod(s) that execute the Job for UATs.
Fixes #96
Manual testing
juju deploy admission-webhook --channel 1.9/stable --trust
juju deploy kubeflow-profiles --channel 1.9/stable --trust
git checkout KF-6029-configure-driver-behind-proxy
tox -e uats-local -- --proxy http_proxy=daniela:9090 https_proxy=daniela:9090 'no_proxy=no,proxy,comma,separated'
Pod
created by the UATsJob
has the desiredEnvironment
vars:admission webhook
logs to ensure it is applying the PodDefault correctly: