Merge KF-5945-configure-proxy-dev-branch into main
#106
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* add poddefault and configure kfp tests * kfp: use dict.get to avoid KeyError * configure katib uats * configure training uats * add testing with proxy instructions to README
* Prefetch mnist dataset in tfjob to solve proxy problems
* tests: add proxy option to test file for driver Adding a proxy option to the driver/test_kubeflow_workloads.py script, will allow users to tell the driver it will run in a proxied environment. With this, a PodDefault will be used for setting environment variables (NO_PROXY, HTTP_PROXY, HTTPS_PROXY) in the Pod(s) that execute the Job for UATs. Fixes #96
NohaIhab
reviewed
Aug 27, 2024
There was a problem hiding this comment.
Thx @DnPlas, there are some small changes we need to make. Left 2 comments.
Testing
I was able to see the CKF uats pass by first configuring knative-serving and kserve-controller:
juju config knative-serving http-proxy=http://10.0.13.50:3128/ https-proxy=http://10.0.13.50:3128/ no-proxy=10.1.0.0/16,10.152.183.0/24,127.0.0.1,10.0.2.0/24,ip-10-0-2-157,.svc,.local,localhost
juju config kserve-controller http-proxy=http://10.0.13.50:3128/ https-proxy=http://10.0.13.50:3128/ no-proxy=10.1.0.0/16,10.152.183.0/24,127.0.0.1,10.0.2.0/24,ip-10-0-2-157,.svc,.local,localhost
then run the uats (excluding mlflow):
tox -e uats-local -- --filter "not mlflow" --proxy http_proxy="http://10.0.13.50:3128/" https_proxy="http://10.0.13.50:3128/" no_proxy="10.1.0.0/16,10.152.183.0/24,127.0.0.1,10.0.2.0/24,ip-10-0-2-157,.svc,.local,localhost"
NohaIhab
reviewed
Aug 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR merges
KF-5945-configure-proxy-dev-branchintomainto support the proxy configuration for UATs.Fixes #75