Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Remove redundant key in site.yaml #356

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: Remove redundant key in site.yaml #356

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 0 additions & 4 deletions konf/site.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,10 +11,6 @@ env:
key: google-custom-search-key
name: google-api

- name: FLASK_SECRET_KEY
secretKeyRef:
key: anbox-cloud-io
name: secret-keys
Comment on lines -14 to -17
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think this is the right solution, when removing we will fall back to the static secret in

anbox-cloud.io/.env

Line 4 in f356969

FLASK_SECRET_KEY=secret_key

We should rather set the key in k8s.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any idea why we need this key? What is it doing?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you follow the code, it is used as https://flask.palletsprojects.com/en/2.3.x/config/#SECRET_KEY

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. I'll investigate further what the issue is with the keys.


production:
replicas: 5
Expand Down
Loading