Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Remove redundant key in site.yaml #356

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: Remove redundant key in site.yaml #356

wants to merge 1 commit into from

Conversation

aaryanporwal
Copy link
Member

@aaryanporwal aaryanporwal commented Oct 4, 2024 •
edited
Loading

Done

  • Remove undefined key from site.yaml causing demo build failures.

Error log:
Screenshot 2024-10-04 at 10 26 28 PM

QA

  • Check out this feature branch
  • Run the site using the command ./run serve
  • View the site locally in your web browser at: http://0.0.0.0:8043/
  • Run through the following QA steps
  • Check if the demo site below is working.

@webteam-app
Copy link

Demo

Jenkins

demos.haus

@aaryanporwal aaryanporwal marked this pull request as draft October 4, 2024 16:51
@aaryanporwal aaryanporwal marked this pull request as ready for review October 4, 2024 16:53
edlerd
edlerd requested changes Oct 4, 2024
View reviewed changes
konf/site.yaml
Comment on lines -14 to -17
- name: FLASK_SECRET_KEY
secretKeyRef:
key: anbox-cloud-io
name: secret-keys
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think this is the right solution, when removing we will fall back to the static secret in

anbox-cloud.io/.env

Line 4 in f356969

FLASK_SECRET_KEY=secret_key

We should rather set the key in k8s.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any idea why we need this key? What is it doing?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you follow the code, it is used as https://flask.palletsprojects.com/en/2.3.x/config/#SECRET_KEY

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. I'll investigate further what the issue is with the keys.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@edlerd edlerd edlerd requested changes

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
Review: Code needed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@aaryanporwal @webteam-app @edlerd