Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests: switch from imp to importlib #3296

Merged
merged 1 commit into from
Jul 12, 2023
Merged

tests: switch from imp to importlib #3296

merged 1 commit into from
Jul 12, 2023

Conversation

ptoscano
Copy link
Contributor

Switch the only test still using imp to importlib, as the former is deprecated since Python 3.4 and removed in Python 3.12.

The result is slightly a bit more code, however it is OK in a single test.

Card ID: ENT-5613

Switch the only test still using 'imp' to 'importlib', as the former is
deprecated since Python 3.4 and removed in Python 3.12.

The result is slightly a bit more code, however it is OK in a single
test.

Card ID: ENT-5613
@cnsnyder cnsnyder requested review from a team and m-horky and removed request for a team July 12, 2023 06:30
@github-actions
Copy link

Coverage

Coverage (computed on Fedora latest) •
FileStmtsMissCoverMissing
TOTAL18048437875% 
report-only-changed-files is enabled. No files were changed during this commit :)

Tests Skipped Failures Errors Time
2632 9 💤 0 ❌ 0 🔥 55.716s ⏱️

@m-horky
Copy link
Contributor

m-horky commented Jul 12, 2023

seb-m/pyinotify#204 :(

@ptoscano
Copy link
Contributor Author

seb-m/pyinotify#204 :(

Yes, I know; the file monitor seems to handle the lack of pyinotify already, so it is only the test that needs to be fixed; I can look at that later. Regardless of that, I'd get this in, so at least the pytest test collection works with Python 3.12.

Copy link
Contributor

@jirihnidek jirihnidek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@m-horky m-horky merged commit 08bfc6f into main Jul 12, 2023
@m-horky m-horky deleted the ptoscano/ENT-5613 branch July 12, 2023 09:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants