Drop further ethtool dependency mentions #3295
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cnsnyder
requested review from
a team and
jirihnidek
and removed request for
a team
Coverage (computed on Fedora latest) •
|
|
generally LGTM; there is another occurrence of |
m-horky
force-pushed
the
mhorky/ethtool-removal
branch
from
b4fb2c3 to
0d5e2a0
Compare
I wish our build/setup tooling wasn't duplicating nearly everything that could be duplicated :) |
|
oh and it seems rawhide got python 3.12 already (still in beta), and one test fails because it still uses |
* Card ID: ENT-5099 This is a follow-up to 4c81d7c > 2215974: Collect network facts using 'ip' While the ethtool dependency was dropped from the .spec file, it was not completely removed from the rest of the build files. This commit fixes that.
m-horky
force-pushed
the
mhorky/ethtool-removal
branch
from
0d5e2a0 to
7493dac
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a follow-up to 4c81d7c and #3284.
While the ethtool dependency was dropped from the .spec file, it was not completely removed from the rest of the build files. This commit fixes that.