fix: Drop deprecated cockpit.resolve() #84
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cockpit.{resolve,reject} have been deprecated for years. Use the
standard JS promise API.
3 tasks
martinpitt
added a commit
to martinpitt/cockpit
that referenced
this pull request
Nov 25, 2024
Commit 132300e was premature, subscription-manager still uses that [1]. Put it back, but in terms of the standard Promise API. [1] candlepin/subscription-manager-cockpit#84
This was referenced Nov 25, 2024
martinpitt
added a commit
to martinpitt/cockpit
that referenced
this pull request
Nov 25, 2024
Commit 132300e was premature, subscription-manager still uses that [1]. Put it back, but in terms of the standard Promise API. Add a deprecation warning. [1] candlepin/subscription-manager-cockpit#84
martinpitt
added a commit
to cockpit-project/cockpit
that referenced
this pull request
Nov 25, 2024
Commit 132300e was premature, subscription-manager still uses that [1]. Put it back, but in terms of the standard Promise API. Add a deprecation warning. [1] candlepin/subscription-manager-cockpit#84
martinpitt
added a commit
to cockpit-project/cockpit
that referenced
this pull request
Nov 25, 2024
Commit 132300e was premature, subscription-manager still uses that [1]. Put it back, but in terms of the standard Promise API. Add a deprecation warning. [1] candlepin/subscription-manager-cockpit#84
clrpackages
pushed a commit
to clearlinux-pkgs/cockpit
that referenced
this pull request
Nov 25, 2024
commit bdd05b451b1650a6cd9c7dbfc6257a71a225f077 Author: Martin Pitt <[email protected]> Date: Mon Nov 25 13:15:12 2024 +0100 cockpit.js: Put back cockpit.{resolve,reject} Commit 132300e09cc45cbd was premature, subscription-manager still uses that [1]. Put it back, but in terms of the standard Promise API. Add a deprecation warning. [1] candlepin/subscription-manager-cockpit#84
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cockpit.{resolve,reject} have been deprecated for years. Use the standard JS promise API.