cockpit.js: Put back cockpit.{resolve,reject} #21321
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
martinpitt
added
the
no-test
This was referenced Nov 25, 2024
Commit 132300e was premature, subscription-manager still uses that [1]. Put it back, but in terms of the standard Promise API. Add a deprecation warning. [1] candlepin/subscription-manager-cockpit#84
martinpitt
force-pushed
the
revert-cockpit-resolve
branch
from
3a12adf
to
7bb54d2
Compare
|
Added a deprecation warning as suggested by @jelly |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Commit 132300e was premature, subscription-manager still uses that [1]. Put it back, but in terms of the standard Promise API.
Add a deprecation warning.
[1] candlepin/subscription-manager-cockpit#84